Enable new language features for F# 5.0 (dotnet#9827)

* Update to fsharp5

* Update preview error messages

* Update error messages

* fix

Author: KevinRansom

src/fsharp/FSharp.Core/prim-types.fsi

@@ -1332,97 +1332,78 @@ namespace Microsoft.FSharp.Core
 
         /// <summary>A compiler intrinsic that implements dynamic invocations to the '-' operator.</summary>
         [<CompilerMessage("This function is for use by dynamic invocations of F# code and should not be used directly", 1204, IsHidden=true)>]
-        [<Experimental("Experimental library feature, requires '--langversion:preview'")>]
         val SubtractionDynamic : x:'T1 -> y:'T2 -> 'U
 
         /// <summary>A compiler intrinsic that implements dynamic invocations to the '/' operator.</summary>
         [<CompilerMessage("This function is for use by dynamic invocations of F# code and should not be used directly", 1204, IsHidden=true)>]
-        [<Experimental("Experimental library feature, requires '--langversion:preview'")>]
         val DivisionDynamic : x:'T1 -> y:'T2 -> 'U
 
         /// <summary>A compiler intrinsic that implements dynamic invocations to the unary '-' operator.</summary>
         [<CompilerMessage("This function is for use by dynamic invocations of F# code and should not be used directly", 1204, IsHidden=true)>]
-        [<Experimental("Experimental library feature, requires '--langversion:preview'")>]
         val UnaryNegationDynamic : value:'T -> 'U
 
         /// <summary>A compiler intrinsic that implements dynamic invocations to the '%' operator.</summary>
         [<CompilerMessage("This function is for use by dynamic invocations of F# code and should not be used directly", 1204, IsHidden=true)>]
-        [<Experimental("Experimental library feature, requires '--langversion:preview'")>]
         val ModulusDynamic : x:'T1 -> y:'T2 -> 'U
 
         /// <summary>A compiler intrinsic that implements dynamic invocations to the checked '-' operator.</summary>
         [<CompilerMessage("This function is for use by dynamic invocations of F# code and should not be used directly", 1204, IsHidden=true)>]
-        [<Experimental("Experimental library feature, requires '--langversion:preview'")>]
         val CheckedSubtractionDynamic : x:'T1 -> y:'T2 -> 'U
 
         /// <summary>A compiler intrinsic that implements dynamic invocations to the checked unary '-' operator.</summary>
         [<CompilerMessage("This function is for use by dynamic invocations of F# code and should not be used directly", 1204, IsHidden=true)>]
-        [<Experimental("Experimental library feature, requires '--langversion:preview'")>]
         val CheckedUnaryNegationDynamic : value:'T -> 'U
 
         /// <summary>A compiler intrinsic that implements dynamic invocations to the '&lt;&lt;&lt;' operator.</summary>
         [<CompilerMessage("This function is for use by dynamic invocations of F# code and should not be used directly", 1204, IsHidden=true)>]
-        [<Experimental("Experimental library feature, requires '--langversion:preview'")>]
         val LeftShiftDynamic : value:'T1 -> shift:'T2 -> 'U
 
         /// <summary>A compiler intrinsic that implements dynamic invocations to the '&gt;&gt;&gt;' operator.</summary>
         [<CompilerMessage("This function is for use by dynamic invocations of F# code and should not be used directly", 1204, IsHidden=true)>]
-        [<Experimental("Experimental library feature, requires '--langversion:preview'")>]
         val RightShiftDynamic : value:'T1 -> shift:'T2 -> 'U
 
         /// <summary>A compiler intrinsic that implements dynamic invocations to the '&amp;&amp;&amp;' operator.</summary>
         [<CompilerMessage("This function is for use by dynamic invocations of F# code and should not be used directly", 1204, IsHidden=true)>]
-        [<Experimental("Experimental library feature, requires '--langversion:preview'")>]
         val BitwiseAndDynamic : x:'T1 -> y:'T2 -> 'U
 
         /// <summary>A compiler intrinsic that implements dynamic invocations to the '|||' operator.</summary>
         [<CompilerMessage("This function is for use by dynamic invocations of F# code and should not be used directly", 1204, IsHidden=true)>]
-        [<Experimental("Experimental library feature, requires '--langversion:preview'")>]
         val BitwiseOrDynamic : x:'T1 -> y:'T2 -> 'U
 
         /// <summary>A compiler intrinsic that implements dynamic invocations related to the '^^^' operator.</summary>
         [<CompilerMessage("This function is for use by dynamic invocations of F# code and should not be used directly", 1204, IsHidden=true)>]
-        [<Experimental("Experimental library feature, requires '--langversion:preview'")>]
         val ExclusiveOrDynamic : x:'T1 -> y:'T2 -> 'U
 
         /// <summary>A compiler intrinsic that implements dynamic invocations related to the '~~~' operator.</summary>
         [<CompilerMessage("This function is for use by dynamic invocations of F# code and should not be used directly", 1204, IsHidden=true)>]
-        [<Experimental("Experimental library feature, requires '--langversion:preview'")>]
         val LogicalNotDynamic : value:'T -> 'U
 
         /// <summary>A compiler intrinsic that implements dynamic invocations related to conversion operators.</summary>
         [<CompilerMessage("This function is for use by dynamic invocations of F# code and should not be used directly", 1204, IsHidden=true)>]
-        [<Experimental("Experimental library feature, requires '--langversion:preview'")>]
         val ExplicitDynamic : value:'T -> 'U
 
         /// <summary>A compiler intrinsic that implements dynamic invocations related to the '&lt;' operator.</summary>
         [<CompilerMessage("This function is for use by dynamic invocations of F# code and should not be used directly", 1204, IsHidden=true)>]
-        [<Experimental("Experimental library feature, requires '--langversion:preview'")>]
         val LessThanDynamic : x:'T1 -> y:'T2 -> 'U
 
         /// <summary>A compiler intrinsic that implements dynamic invocations related to the '&gt;' operator.</summary>
         [<CompilerMessage("This function is for use by dynamic invocations of F# code and should not be used directly", 1204, IsHidden=true)>]
-        [<Experimental("Experimental library feature, requires '--langversion:preview'")>]
         val GreaterThanDynamic : x:'T1 -> y:'T2 -> 'U
 
         /// <summary>A compiler intrinsic that implements dynamic invocations related to the '&lt;=' operator.</summary>
         [<CompilerMessage("This function is for use by dynamic invocations of F# code and should not be used directly", 1204, IsHidden=true)>]
-        [<Experimental("Experimental library feature, requires '--langversion:preview'")>]
         val LessThanOrEqualDynamic : x:'T1 -> y:'T2 -> 'U
 
         /// <summary>A compiler intrinsic that implements dynamic invocations related to the '&gt;=' operator.</summary>
         [<CompilerMessage("This function is for use by dynamic invocations of F# code and should not be used directly", 1204, IsHidden=true)>]
-        [<Experimental("Experimental library feature, requires '--langversion:preview'")>]
         val GreaterThanOrEqualDynamic : x:'T1 -> y:'T2 -> 'U
 
         /// <summary>A compiler intrinsic that implements dynamic invocations related to the '=' operator.</summary>
         [<CompilerMessage("This function is for use by dynamic invocations of F# code and should not be used directly", 1204, IsHidden=true)>]
-        [<Experimental("Experimental library feature, requires '--langversion:preview'")>]
         val EqualityDynamic : x:'T1 -> y:'T2 -> 'U
 
         /// <summary>A compiler intrinsic that implements dynamic invocations related to the '=' operator.</summary>
         [<CompilerMessage("This function is for use by dynamic invocations of F# code and should not be used directly", 1204, IsHidden=true)>]
-        [<Experimental("Experimental library feature, requires '--langversion:preview'")>]
         val InequalityDynamic : x:'T1 -> y:'T2 -> 'U
 
         /// <summary>A compiler intrinsic that implements dynamic invocations for the DivideByInt primitive.</summary>

src/fsharp/FSharp.Core/quotations.fsi

@@ -130,7 +130,6 @@ type Expr =
     /// <param name="arguments">The list of arguments to the method.</param>
     ///
     /// <returns>The resulting expression.</returns>
-    [<Experimental("Experimental library feature, requires '--langversion:preview'")>]
     static member CallWithWitnesses: methodInfo: MethodInfo * methodInfoWithWitnesses: MethodInfo * witnesses: Expr list * arguments: Expr list -> Expr
 
     /// <summary>Builds an expression that represents a call to an instance method associated with an object</summary>
@@ -142,7 +141,6 @@ type Expr =
     /// <param name="arguments">The list of arguments to the method.</param>
     ///
     /// <returns>The resulting expression.</returns>
-    [<Experimental("Experimental library feature, requires '--langversion:preview'")>]
     static member CallWithWitnesses: obj:Expr * methodInfo:MethodInfo * methodInfoWithWitnesses: MethodInfo * witnesses: Expr list * arguments:Expr list -> Expr
 
     /// <summary>Builds an expression that represents the coercion of an expression to a type</summary>
@@ -607,7 +605,6 @@ module Patterns =
     ///
     /// <returns>When successful, the pattern binds the object, method, witness-argument and argument sub-expressions of the input expression</returns>
     [<CompiledName("CallWithWitnessesPattern")>]
-    [<Experimental("Experimental library feature, requires '--langversion:preview'")>]
     val (|CallWithWitnesses|_|) : input:Expr -> (Expr option * MethodInfo * MethodInfo * Expr list * Expr list) option
 
     /// <summary>An active pattern to recognize expressions that represent coercions from one type to another</summary>

src/fsharp/LanguageFeatures.fs

@@ -23,7 +23,7 @@ type LanguageFeature =
     | RelaxWhitespace
     | NameOf
     | ImplicitYield
-    | OpenTypeDeclaration
+    | OpenStaticClasses
     | DotlessFloat32Literal
     | PackageManagement
     | FromEndSlicing
@@ -34,7 +34,6 @@ type LanguageFeature =
     | WitnessPassing
     | InterfacesWithMultipleGenericInstantiation
     | StringInterpolation
-    | OverloadsForCustomOperations
 
 /// LanguageVersion management
 type LanguageVersion (specifiedVersionAsString) =
@@ -65,16 +64,15 @@ type LanguageVersion (specifiedVersionAsString) =
             LanguageFeature.AndBang, languageVersion50
             LanguageFeature.NullableOptionalInterop, languageVersion50
             LanguageFeature.DefaultInterfaceMemberConsumption, languageVersion50
+            LanguageFeature.OpenStaticClasses, languageVersion50
+            LanguageFeature.PackageManagement, languageVersion50
+            LanguageFeature.WitnessPassing, languageVersion50
+            LanguageFeature.InterfacesWithMultipleGenericInstantiation, languageVersion50
+            LanguageFeature.NameOf, languageVersion50
 
             // F# preview
             LanguageFeature.FromEndSlicing, previewVersion
-            LanguageFeature.OpenTypeDeclaration, previewVersion
-            LanguageFeature.PackageManagement, previewVersion
-            LanguageFeature.WitnessPassing, previewVersion
-            LanguageFeature.InterfacesWithMultipleGenericInstantiation, previewVersion
-            LanguageFeature.NameOf, previewVersion
             LanguageFeature.StringInterpolation, previewVersion
-            LanguageFeature.OverloadsForCustomOperations, previewVersion
         ]
 
     let specified =
@@ -135,7 +133,7 @@ type LanguageVersion (specifiedVersionAsString) =
         | LanguageFeature.RelaxWhitespace -> FSComp.SR.featureRelaxWhitespace()
         | LanguageFeature.NameOf -> FSComp.SR.featureNameOf()
         | LanguageFeature.ImplicitYield -> FSComp.SR.featureImplicitYield()
-        | LanguageFeature.OpenTypeDeclaration -> FSComp.SR.featureOpenTypeDeclaration()
+        | LanguageFeature.OpenStaticClasses -> FSComp.SR.featureOpenStaticClasses()
         | LanguageFeature.DotlessFloat32Literal -> FSComp.SR.featureDotlessFloat32Literal()
         | LanguageFeature.PackageManagement -> FSComp.SR.featurePackageManagement()
         | LanguageFeature.FromEndSlicing -> FSComp.SR.featureFromEndSlicing()
@@ -146,7 +144,6 @@ type LanguageVersion (specifiedVersionAsString) =
         | LanguageFeature.WitnessPassing -> FSComp.SR.featureWitnessPassing()
         | LanguageFeature.InterfacesWithMultipleGenericInstantiation -> FSComp.SR.featureInterfacesWithMultipleGenericInstantiation()
         | LanguageFeature.StringInterpolation -> FSComp.SR.featureStringInterpolation()
-        | LanguageFeature.OverloadsForCustomOperations -> FSComp.SR.featureOverloadsForCustomOperations()
 
     /// Get a version string associated with the given feature.
     member _.GetFeatureVersionString feature =

tests/FSharp.Compiler.ComponentTests/ErrorMessages/InvalidNumericLiteralTests.fs

@@ -60,8 +60,8 @@ module ``Numeric Literals`` =
     [<Fact>]
     let ``1N is invalid numeric literal in FSI``() =
         if Utils.runningOnMono then ()
-        else
-            CompilerAssert.RunScriptWithOptions [| "--langversion:preview"; "--test:ErrorRanges" |]
+        else 
+            CompilerAssert.RunScriptWithOptions [| "--langversion:5.0"; "--test:ErrorRanges" |]
                 """
 let x = 1N
                 """

tests/FSharp.Compiler.ComponentTests/Language/CodeQuotationTests.fs

@@ -36,6 +36,6 @@ let z : unit =
         failwithf "did not expect expression for 'z': %A" e
         """
         |> asExe
-        |> withLangVersionPreview
+        |> withOptions ["--langversion:5.0"]
         |> compileAndRun
         |> shouldSucceed

tests/fsharp/Compiler/Language/InterfaceTests.fs

@@ -180,7 +180,7 @@ assertion (fun (x:float) -> x * 3.0) (fun v ->
                 ``Many Instantiations of the same interface - Asserts``,
                 Fs, Library,
                 options = [|
-                    "--langversion:preview";
+                    "--langversion:5.0";
 #if !NETSTANDARD
                 |])
 #else
@@ -203,7 +203,7 @@ assertion (fun (x:float) -> x * 3.0) (fun v ->
             |]
             ``Many Instantiations of the same interface``
             [|
-                (FSharpErrorSeverity.Error, 3350, (24, 6, 24, 20), "Feature 'interfaces with multiple generic instantiation' is not available in F# 4.7. Please use language version 'preview' or greater.")
+                (FSharpErrorSeverity.Error, 3350, (24, 6, 24, 20), "Feature 'interfaces with multiple generic instantiation' is not available in F# 4.7. Please use language version 5.0 or greater.")
             |]
 
     [<Test>]