Skip to content
This repository was archived by the owner on Jan 13, 2025. It is now read-only.

Conversation

@jpobst
Copy link
Contributor

@jpobst jpobst commented Nov 8, 2022

Enable CodeQL static analysis for AndroidX and GPS repositories.

Note this .yaml is not used by this repository.

Only run CodeQL on the Windows build lane.

It's hard to test this since it only runs on main builds, but I did run a test against AndroidX with dotnet/android-libraries#651 to at least ensure that normal builds do not break.

@jpobst jpobst marked this pull request as ready for review November 8, 2022 19:36
@jpobst jpobst requested a review from pjcollins November 8, 2022 19:36
@pjcollins
Copy link
Member

@jpobst how long are the windows builds for AndroidX and GPS? I'm concerned about bloating build times and am wondering if we should be creating "compliance" pipeline for this instead.

@jpobst
Copy link
Contributor Author

jpobst commented Nov 8, 2022

The actual build step of AndroidX is about 35 minutes, GPS is about 65 minutes.

@pjcollins
Copy link
Member

You can test by adding the init/finalize tasks explicitly to the pipeline (see parts of https://github.com/xamarin/xamarin-android/pull/7522/files#diff-fd693a495110ebb53e1d597b60e531a52fc10bd9f9004e7a3c5665b2f0accda9R44). It may be worth doing this before merging to make sure things still work and that we don't make these builds way too long. Given those timings I think we may want to try to set up a separate duplicate build job that does not publish any artifacts but will run CodeQL and other compliance tasks.

@jpobst
Copy link
Contributor Author

jpobst commented Nov 8, 2022

Since it's only one main build every 72 hours I think we should just live with it for now. The whole CI for these is a mess which I hope to clean up in the next few months.

@jpobst jpobst merged commit 436bd3e into main Nov 9, 2022
@jpobst jpobst deleted the codeql branch November 9, 2022 20:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants