This repository was archived by the owner on Jan 13, 2025. It is now read-only.
[Xamarin.Build.Download] Guard against race condition when multiple processes are downloading same artifact. #1407
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occasionally on CI we see messages like this:
In the log we can see that we tried to use XDB to download this file twice at the same time:
The first one succeeds but the second one fails with the "file already exists" errors.
Attempt to guard against this by checking for the "already downloaded" flag a second time once we acquire the directory lock. This way we should bail if another process completed the download while we were waiting for them to release the lock.