This repository was archived by the owner on Jan 13, 2025. It is now read-only.
[Xamarin.Build.Download] Support pre-release package ids. #1384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpobst
force-pushed
the
xbd-pre-release
branch
3 times, most recently
from
df0518e to
84d405d
Compare
|
NuGet semver docs, for reference: https://docs.microsoft.com/en-us/nuget/concepts/package-versioning |
moljac
approved these changes
Jul 28, 2022
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jonathanpeppers
approved these changes
Jul 28, 2022
|
|
||
| <PropertyGroup> | ||
| <TargetFramework>netcoreapp3.0</TargetFramework> | ||
| <TargetFramework>net6</TargetFramework> |
There was a problem hiding this comment.
Hmm, didn't realize this worked, most people put:
Suggested change
| <TargetFramework>net6</TargetFramework> | |
| <TargetFramework>net6.0</TargetFramework> | |
There was a problem hiding this comment.
net6 works, but you were right net6.0 is preferred.
This was referenced Oct 13, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: xamarin/GooglePlayServicesComponents#617
Context: xamarin/GooglePlayServicesComponents#621
Context: xamarin/GooglePlayServicesComponents#624
GPS binds 2 pre-release packages:
Attempting to consume these results in XBD errors because the pre-release specifier is rejected:
We need to expand our version regex to support pre-release specifiers so these can be downloaded.