This repository was archived by the owner on Jan 13, 2025. It is now read-only.
[ci] Add custom build steps that run after the API Diff. #1379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpobst
force-pushed
the
post-api-diff
branch
4 times, most recently
from
11ccaf1 to
7830daa
Compare
|
failing? |
moljac
approved these changes
Jun 2, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In AndroidX dotnet/android-libraries#558, we added a new check that ensure all new namespaces are approved. This
postBuildStepruns correctly, however it runs before the API Diff generator.In the case where this new check fails and aborts the build, it would be nice to have access to the API-diffs to see the new API to review.
This PR adds a new
postDiffBuildStepssection where custom steps can be run after the API Diff is run.Note:
mainfor this repository seems to be broken. This PR only affectsbuild.yml, which is not used by this repository's CI.