This repository was archived by the owner on Jan 13, 2025. It is now read-only.
[Guava.ListenableFuture] Create a 9999.0 version without the .jar to match Maven. #1366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Leaving this as a draft so it doesn't get accidentally committed. |
jonathanpeppers
approved these changes
Apr 21, 2022
Member
jonathanpeppers
left a comment
jonathanpeppers
left a comment
There was a problem hiding this comment.
LGTM, would we probably just keep this on a guava-9999 branch forever?
Contributor
Author
|
Published and unlisted: |
jpobst
added a commit
to dotnet/android-libraries
that referenced
this pull request
Sep 26, 2024
…979) Note this changes the previous `.jar + .targets` behavior to the updated `dotnet` "`.jar/.aar` next to the `.dll`" method. As part of this we do lose the `$(XamarinGoogleGuavaOptOut)` opt-out we had previously added. Given that this was added to help with broken Guava packages published before April 2022, this property should no longer be needed: xamarin/XamarinComponents#1366
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE THIS TO
main, THIS WILL BE PUBLISHED OUT OF THE BRANCHCreates a
9999.0.0version ofXamarin.Google.Guava.ListenableFuturethat does not includeguava-listenablefuture.jar. This version of the package will be the dependency forXamarin.Google.Guava. It will be delisted so that it does not show up for people adding an explicit reference toXamarin.Google.Guava.ListenableFuture.This mirrors the way Google/Maven have set this up:
https://mvnrepository.com/artifact/com.google.guava/listenablefuture
There are 3 scenarios we need to cover to ensure one (and only one) copy of
ListenableFuture.classis included in an application.Xamarin.Google.Guava.ListenableFuture1.0.0.7)ListenableFuture.classwill be provided byguava-listenablefuture.jarXamarin.Google.GuavaXamarin.Google.Guavawill have a dependency onXamarin.Google.Guava.ListenableFuture9999.0which does not includeguava-listenablefuture.jar.ListenableFuture.classwill be provided byguava.jarXamarin.Google.Guava.ListenableFutureandXamarin.Google.GuavaXamarin.Google.Guava's dependency onXamarin.Google.Guava.ListenableFuture9999.0will ensure this version is used.ListenableFuture.classwill be provided byguava.jarNote
9999.0package does not includeguava-listenablefuture.jarorXamarin.Google.Guava.ListenableFuture.targets.Note that we do provide managed bindings for
Xamarin.Google.Guava.ListenableFuture, however we do not provide any managed bindings forXamarin.Google.Guava. Thus the9999.0must still include the C# binding ofListenableFuturefor applications that use it, sinceXamarin.Google.Guavawill not.