This repository was archived by the owner on Apr 6, 2021. It is now read-only.
Support versions of XA without linksrc directory #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: dotnet/android@2ea31e6 Context: dotnet/android@master...jonathanpeppers:androidx-migration-test To improve build performance we have dropped the `linksrc` directory from Xamarin.Android. This dramatically improved the overall file size of the `obj` directory and helped with PCs running Windows Defender. This unfortunately broke the AndroidX.Migration for `Release` builds, but we can fix it: * If `$(MonoAndroidLinkerInputDir)` is non-empty we can use the existing behavior, otherwise... * We can do a `<Copy/>` of the assemblies to `obj\Release\androidx\cecil`. * pdb/mdb files, too! * `<CecilfyFiles/>` can then use the files in `androidx\cecil` directory. * Lastly, we will have to patch up `@(ResolvedAssemblies)` and `@(ResolvedUserAssemblies)` to use the new files. Other changes: * Updated `.gitignore` for `Resource.designer.cs`
Member
Author
|
Here is a build log where I used this on XA master: msbuild.zip |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/android@2ea31e6
Context: dotnet/android@master...jonathanpeppers:androidx-migration-test
To improve build performance we have dropped the
linksrcdirectoryfrom Xamarin.Android. This dramatically improved the overall file size
of the
objdirectory and helped with PCs running Windows Defender.This unfortunately broke the AndroidX.Migration for
Releasebuilds,but we can fix it:
$(MonoAndroidLinkerInputDir)is non-empty we can use theexisting behavior, otherwise...
<Copy/>of the assemblies toobj\Release\androidx\cecil.<CecilfyFiles/>can then use the files inandroidx\cecildirectory.
@(ResolvedAssemblies)and@(ResolvedUserAssemblies)to use the new files.Other changes:
.gitignoreforResource.designer.cs