Skip to content

Add all spell events to ClosureEvents #235

@WareditorGit

Description

@WareditorGit

It would be useful to have all those events in ClosureEvents:
EVENT_PLAYER_UNIT_SPELL_CHANNEL
EVENT_PLAYER_UNIT_SPELL_CAST
EVENT_PLAYER_UNIT_SPELL_EFFECT
EVENT_PLAYER_UNIT_SPELL_FINISH
EVENT_PLAYER_UNIT_SPELL_ENDCAST

Issue is that onCast is used for the EVENT_PLAYER_UNIT_SPELL_EFFECT event so we would have to find different names. After a conversation with @Frotty we came up with (in order):
onChannel, onStart, onCast, onFinish and onEnd.
Would be nice to have some feedback/suggestions before doing the PR.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions