Remove unnecessary methods for silence warnings #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a configuration to suppress warnings, but I think it's probably no longer necessary after the following commit: wspurgin@8066f7c
wspurgin
reviewed
Jul 15, 2025
Comment on lines
-31
to
-37
| def silence_warning(symbol) | ||
| @silence_warnings << symbol | ||
| end | ||
|
|
||
| def warn_for?(symbol) | ||
| !@silence_warnings.include?(symbol) | ||
| end |
Owner
There was a problem hiding this comment.
While it's not being leveraged as of today, it is a public API configuration element (see https://github.com/wspurgin/rspec-sidekiq/wiki/have_enqueued_sidekiq_job-without-argument-default-behavior#silence-warnings)
I left it in to allow future breaking changes to be communicated but silenced if someone wished. I'm not opposed to removing it, but doing so would be a "breaking" change technically (and I think we should release some of the other cleanup and bugfixes first before doing any breaking changes).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a configuration to suppress warnings, but I think it's probably no longer necessary after the following commit: 8066f7c