Skip to content

PR of #32 issue #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 5, 2025
Merged

PR of #32 issue #35

merged 5 commits into from
Mar 5, 2025

Conversation

@gauravrmt
Copy link
Collaborator

@gauravrmt gauravrmt commented Mar 5, 2025

Fixes and refactorings

  • swagger documentation.
  • make res_type query param of check-ip api selectable.

Changes

  • added /monetory/currency-denomination api
  • added basic setup of postgres database.

gauravrmt and others added 5 commits March 4, 2025 17:02
@gauravrmt
fix: #32 changes
9e62f69 
### Fixes
- splitted the `basic utilities` general section into `specific utilities` section.
- converted the `res_type` query parameter selectable
@gauravrmt
fix: #32 issue
58eaf99 
### Fixes
- add the `[GET] /monetory/currency-denomination` API and place it into the monetory-utilities section.
@gauravrmt
fix: #32 changes
ab05711 
### Fixes
- changed variable name
@gauravrmt
fix: #32 changes
5bc59d8 
### Fixes
- added basic setup of `postgres` database.
@sahityagaurav4210
Merge pull request #34 from works-ac/32-fix-basic-utilities-documenta…
78443ce 
…tion

fix: #32 changes
@gauravrmt gauravrmt added bug Something isn't working enhancement New feature or request refactorings Code and other refactorings labels Mar 5, 2025
@gauravrmt gauravrmt self-assigned this Mar 5, 2025
@gauravrmt gauravrmt moved this to In review in Api Pool Mar 5, 2025
@gauravrmt gauravrmt linked an issue Mar 5, 2025 that may be closed by this pull request
Fix basic utilities documentation #32
Closed
sahityagaurav4210
sahityagaurav4210 approved these changes Mar 5, 2025
View reviewed changes
Copy link
Collaborator

@sahityagaurav4210 sahityagaurav4210 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Message: looks good
Reviewed by: @sahityagaurav4210

@sahityagaurav4210 sahityagaurav4210 merged commit ca0f65c into main Mar 5, 2025
@github-project-automation github-project-automation bot moved this from In review to Done in Api Pool Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sahityagaurav4210 sahityagaurav4210 sahityagaurav4210 approved these changes

Assignees

@gauravrmt gauravrmt

Labels

bug Something isn't working enhancement New feature or request refactorings Code and other refactorings

Projects

Api Pool
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix basic utilities documentation

3 participants

@gauravrmt @sahityagaurav4210