Add dependency for GOM demo #981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Gom as dependency for Gom demo ref #workbenchdev/demos#200
sonnyp
previously requested changes
Aug 13, 2024
Contributor
sonnyp
left a comment
sonnyp
left a comment
There was a problem hiding this comment.
Please move to a file in modules/gom.json and use the http archive
like other dependencies such as https://github.com/workbenchdev/Workbench/blob/main/build-aux/modules/libshumate.json
create gom.json for dependencies remove redundant use in devel
andyholmes
approved these changes
Aug 16, 2024
andyholmes
dismissed
sonnyp’s stale review
Requested changes have been made, so proceeding with merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.