Skip to content

Library: Port 'Spell Checker' to Python #758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2023
Merged

Library: Port 'Spell Checker' to Python #758

merged 1 commit into from
Nov 14, 2023

Conversation

@UrtsiSantsi
Copy link
Contributor

@UrtsiSantsi UrtsiSantsi commented Oct 31, 2023

No description provided.

@UrtsiSantsi
Copy link
Contributor Author

UrtsiSantsi commented Oct 31, 2023

@theCapypara I didn't require version for Spelling since I don't know which one it is :)
@sonnyp Both the JavaScript and the Python don't work correctly - if you click on the first incorrect word (no matter what it is) the underline disappears. In some case all the underlines in the control disappear. I tested the same scenarios in Gnome Text and it doesn't have such problems. I also checked the demo Python on the libspelling site and it looks similar (the same?) as my Python code.

@UrtsiSantsi UrtsiSantsi mentioned this pull request Oct 31, 2023
Closed
@sonnyp
Copy link
Contributor

sonnyp commented Oct 31, 2023

The libspelling version is 1.

About the Spelling bug – can you report the issue to libspelling with a small Python and/or GJS reproducer ? (standalone, not Workbench)

theCapypara
theCapypara approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@theCapypara theCapypara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The demo works just as well as the JS demo. The issue with the underline is (probably?) a bug in libspelling.

@theCapypara theCapypara merged commit 7290ac0 into main Nov 14, 2023
@theCapypara theCapypara deleted the python_spell_checker branch November 14, 2023 13:09
lw64 pushed a commit that referenced this pull request Dec 18, 2023
@UrtsiSantsi @lw64
Library: Port 'Spell Checker' to Python (#758)
aa74c96
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@theCapypara theCapypara theCapypara approved these changes

Assignees

No one assigned

Labels

Library 📚️ python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@UrtsiSantsi @sonnyp @theCapypara