Library: Port 'Color Picker' to Python #741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
UrtsiSantsi
reviewed
Nov 1, 2023
|
|
||
| def on_selected(_portal, task): | ||
| r, g, b = _portal.pick_color_finish(task) | ||
| print(r, g, b) |
Contributor
|
The PyGObject bindings for RGBA do not take arguments anymore. See: https://gitlab.gnome.org/GNOME/pygobject/-/issues/560#note_1607269 |
Contributor
Author
|
@theCapypara Thanks, that was the problem. My latest commit fixes the problem, although it somehow feels a bit weird, not sure if it's deviating too much from the JS version. |
theCapypara
approved these changes
Nov 11, 2023
Contributor
theCapypara
left a comment
theCapypara
left a comment
There was a problem hiding this comment.
LGTM! The way you assign to RGBA now looks fine to me as well. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't work yet. Somehow
Gdk.RGBAdoesn't properly set the color values, only to(0,0,0,0)