python: Init GtkSource (+ minor formatting/style fixes) #736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonnyp
approved these changes
Oct 30, 2023
Contributor
sonnyp
left a comment
sonnyp
left a comment
There was a problem hiding this comment.
We might need something similar for WebKitGTK / Soup
can't remember
sonnyp
reviewed
Oct 30, 2023
Comment on lines
+31
to
+32
| # Load non-GTK widget types | ||
| GtkSource.init() |
Contributor
There was a problem hiding this comment.
we might want to do this in the demo code too
so that the code works when they copy paste it to their app
Contributor
Author
There was a problem hiding this comment.
Good idea. Also the reason why I decided to keep the "gi.requires_version" in there too. We may also want to update the JS demos to specify the versions on import then.
Contributor
There was a problem hiding this comment.
We may also want to update the JS demos to specify the versions on import then.
I've been having an internal war on this - it's ... tricky.
reminder to talk about this : #738
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did not realize one needed to call
GtkSource.init()from PyGObject. Currently PyGObject automatically inits the core namespaces, so I figured it did the same forGtkSource(this is also what I remembered from other apps I worked on).Also contains one code style fix and one formatting fix for demos.
Closes #713.