Implement Python formatting with black #720
Conversation
| @@ -0,0 +1,20 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
This is for local execution. See package.json.
| gi.require_version("Adw", "1") | ||
| from gi.repository import Gtk, Adw | ||
| import workbench | ||
|
|
There was a problem hiding this comment.
This is the pre-commit hook doing its magic :)
sonnyp
left a comment
sonnyp
left a comment
There was a problem hiding this comment.
One more thing I forgot, could you add a check to make lint (Makefile) that errors if the code isn't formatted ?
This runs as part of github workflow
| of black and their dependencies and add them to the JSON as well. Brute-forcing the build to obtain missing packages | ||
| may help as does referencing old commits of the file. You can also use the generator command to generate dependencies | ||
| for them and then merge it into the file by hand, but note that you will also need to manually collect their build | ||
| dependencies too. |
| fi | ||
| fi | ||
|
|
||
| exec black "$@" |
There was a problem hiding this comment.
Ideally we would use Flatpak
Could black be part of a Python sdk at some point?
An other option is to build the Workbench Flatpak once before running the pre-commits
And using the tooling from within the Workbench runtime
There was a problem hiding this comment.
Would probably be useful to have in the SDK. I feel like pre-building the Workbench Flatpak is a bit convoluted and error prone.
|
Nevermind - it's already there :) |
sonnyp
changed the title
I hope the README.md I added is OK, it's a bit of an unfortunate situation but it wasn't too bad to get it working.
Closes #716