Use runtime extensions instead of copying into /app #639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonnyp
force-pushed
the
use-sdk-extensions
branch
from
7ba7e30 to
66bdb07
Compare
Closed
sonnyp
commented
Sep 24, 2023
Comment on lines
+9
to
+11
| source /usr/lib/sdk/rust-stable/enable.sh | ||
| source /usr/lib/sdk/vala/enable.sh | ||
| source /usr/lib/sdk/llvm16/enable.sh |
sonnyp
commented
Sep 24, 2023
Comment on lines
+123
to
+130
| browse_list_view.model = createBrowseSelectionModel(root_model, webview); | ||
|
|
||
| scanLibraries(root_model, base_path) | ||
| .then(() => { | ||
| browse_list_view.model.selected = 12; | ||
| const search_model = flattenModel(root_model); | ||
| filter_model.model = search_model; | ||
| }) | ||
| .catch(console.error); | ||
| await scanLibraries(root_model, Gio.File.new_for_path("/usr/share/doc")); | ||
| browse_list_view.model.selected = 12; | ||
| await scanLibraries(root_model, Gio.File.new_for_path("/app/share/doc")); | ||
|
|
||
| browse_list_view.model = createBrowseSelectionModel(root_model, webview); | ||
| const search_model = flattenModel(root_model); | ||
| filter_model.model = search_model; |
Contributor
Author
|
@Hofer-Julian what should I do about the cargo files? |
Contributor
Author
|
I'm merging this to move forward and avoid rebases/rebuilds, but please do review, and I'll address the comments in followups. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #621 by implementing #621 (comment)
Fixes #615
Quick measurement With GNOME Builder export (
.flatpak):It has the nice side effect of removing workarounds, making the dev env and sandbox env exactly the same and speed up dev/export
Also:
strip: falsestuff as it is not needed anymorepost-installin favor of using sdk extensions as runtime extensionsTodo:
/usr/share/docand/app/share/doc