-
-
Notifications
You must be signed in to change notification settings - Fork 90
library: Add Rust file for demos without code #579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sonnyp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
Because od the way the previewer is set up. The demos without Javascript code don't compile in Rust. |
|
I see, the problem is when opening a Library demo that is not ported yet and pressing "Run". We currently show this in the Code panel and an error in the console (at least for Rust) which is more useful.
Here are a couple of non exclusive ideas: When the demo is not available in the currently selected Code lang
|
This is about demos that have no javascript code, not demos that are not ported yet :) |
|
Should have been more specific in the PR, sorry for that. |
|
Ha, gotcha. I wonder if we shouldn't just hide the |
|
Let's chat, will be easier. |
lw64
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If its not too much work for you, it would be nice to havea line brak after the {, but its really not important.
|
But thanks for the work :) |
sonnyp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you !
Regarding the line break, I'll take care of it, the Vala formatter will fix it
No description provided.