patch to BIM60 connector #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

sophatsam wants to merge 44 commits into workato:svchandra-bim_360 from sophatsam:sophatsam-bim_360

+434 −1,466

sophatsam commented Sep 9, 2019

No description provided.

sophatsam added 30 commits

August 28, 2019 13:23


          update modify_rfi object definition to match order of inputs

b3dddcc


          update rfi object definition, remove unnecessary info

f73b516


          update new rfi trigger to include hub_id, project_id, and `cont…

cc6f3ca

…ainer_id`


          update rfis_container_lists picklist so it does not error when `hub…

4b45f45

…_id` is dynamic value


          update project_list pick list to not error when hub_id is dynamic…

9d8742c

…ally entered


          update issue object definition, remove unnecessary fields

a6a3060


          update create issue action, output hub_id and container_id in r…

83fcf22

…esult


          update search issues action, output hub_id, project_id, and `co…

bb06a46

…ntainer_id` in result


          update update issue action, include correct headers, output `hub_id…

5b51e4d

…` and `container_id` in result


          update get issue action, output hub_id and container_id

55f304c


          update new issue.. trigger, remove additional include parameters,…

1c2e35e

… output `hub_id`, `project_id`, and `container_id`


          update issue_container_lists picklist to ignore dynamic hub_id

80ba213


          update rfi object definition, remove unnecessary output

f71b504


          update search rfis... action, output hub_id and container_id in…

2131b69

… result


          update get rfi action, include hub_id and container_id in result

8d2d83e


          update create rfi... action, include correct headers, output `hub_i…

60f8248

…d` and `container_id`


          update update rfi.. action, include correct headers, output `hub_id…

b85968b

…` and `container_id`


          update title for get issue... action

c39b277


          remove search projects.. action

8aaf738


          update items object definition

a62db51


          update folder_files object definition

9e389df


          update get folder details... action, output hub_id, project_id,…

eec5d3e

… and `folder_id`


          update get folder contents... action, include filters parameter, …

963e8db

…output `hub_id`, `project_id`, and `folder_id`


          update get documents... action, output hub_id and project_id

7dce31d


          update download document action, remove required field for folder

7b4a6b3


          update upload document... action, remove object_type, include `fi…

ef1b395

…le_content` in `PUT` payload, output `hub_id` and `project_id`


          update new or updated document... trigger, output hub_id, `projec…

61f7fc0

…t_id`, and `folder_id`


          update folder_items picklist to not error if project_id is dynamic

12fbbee


          update folders_list picklist to not error when project_id is dynamic

79d19e0


          misc edits from Chandra's connector version

c827043

svchandra reviewed

View reviewed changes

custom_connectors/oauth2/bim_360.rb Outdated

    
            @@ -2301,7 +1399,7 @@
          
                      [

                        {

                          name: 'hub_id',

                          label: 'Hub name',

                          label: 'Hub Name',

Contributor

svchandra Sep 9, 2019

Update label as

label: 'Hub name',

svchandra reviewed

View reviewed changes

custom_connectors/oauth2/bim_360.rb Outdated

    
            @@ -2317,7 +1415,7 @@
          
                        },

                        {

                          name: 'project_id',

                          label: 'Project name',

                          label: 'Project Name',

Contributor

svchandra Sep 9, 2019

Update label as

label: 'Project name',

svchandra reviewed

View reviewed changes

custom_connectors/oauth2/bim_360.rb Outdated

    
            @@ -2377,7 +1481,7 @@
          
                      [

                        {

                          name: 'hub_id',

                          label: 'Hub name',

                          label: 'Hub Name',

Contributor

svchandra Sep 9, 2019

Update label as

label: 'Hub name',

svchandra reviewed

View reviewed changes

custom_connectors/oauth2/bim_360.rb Outdated

    
            @@ -2393,7 +1497,7 @@
          
                        },

                        {

                          name: 'project_id',

                          label: 'Project name',

                          label: 'Project Name',

Contributor

svchandra Sep 9, 2019

Update label as

label: 'Project name',

svchandra reviewed

View reviewed changes

custom_connectors/oauth2/bim_360.rb Outdated

    
                          control_type: 'text',

                          sticky: true,

                          hint: 'Enter filters for the search. A list of filters can be' \

                          ' found at https://forge.autodesk.com/en/docs/data/v2/' \

Contributor

svchandra Sep 9, 2019

Use hyper link tag
e.g

hint: 'To create client ID, the system admin or manager can click ' \
        "<a href='https://abc.com/app/settings/developer/apps/new' " \
        "target='_blank'>here</a> to register a new client application." },

svchandra reviewed

View reviewed changes

custom_connectors/oauth2/bim_360.rb Outdated

    
            @@ -2461,7 +1575,7 @@
          
                      [

                        {

                          name: 'hub_id',

                          label: 'Hub name',

                          label: 'Hub Name',

Contributor

svchandra Sep 9, 2019

Update label as

label: 'Hub name',

svchandra reviewed

View reviewed changes

custom_connectors/oauth2/bim_360.rb Outdated

    
            @@ -2477,7 +1591,7 @@
          
                        },

                        {

                          name: 'project_id',

                          label: 'Project name',

                          label: 'Project Name',

Contributor

svchandra Sep 9, 2019

Update label as

label: 'Project name',

svchandra reviewed

View reviewed changes

custom_connectors/oauth2/bim_360.rb Outdated

    
            @@ -2511,10 +1625,10 @@
          
                            hint: 'Use Folder ID'

                          } },

                        { name: 'item_id',

                          label: 'File name',

                          label: 'File Name',

Contributor

svchandra Sep 9, 2019

Update label as

 label: 'File name',

svchandra reviewed

View reviewed changes

custom_connectors/oauth2/bim_360.rb Outdated

    
                    },

                    config_fields:

                      [

                        {

                          name: 'hub_id',

                          label: 'Hub name',

                          label: 'Hub Name',

Contributor

svchandra Sep 9, 2019

update label as

 label: 'Hub name',

svchandra reviewed

View reviewed changes

custom_connectors/oauth2/bim_360.rb Outdated

    
            @@ -2573,7 +1687,7 @@
          
                        },

                        {

                          name: 'project_id',

                          label: 'Project name',

                          label: 'Project Name',

Contributor

svchandra Sep 9, 2019

Update label as

label: 'Project name',

svchandra reviewed

View reviewed changes

custom_connectors/oauth2/bim_360.rb Outdated

    
                        {

                          name: 'item_id',

                          label: 'File name',

                          label: 'File Name',

Contributor

svchandra Sep 9, 2019

Update label as

label: 'File name'```

svchandra reviewed

View reviewed changes

custom_connectors/oauth2/bim_360.rb Outdated

    
                            optional: true,

                            toggle_hint: 'Use custom value',

                            hint: 'Use version number'

                            hint: 'Use File/Item ID'

Contributor

svchandra Sep 9, 2019 •

edited

Loading

Update hint

hint: 'Use fileiItem ID'

svchandra reviewed

View reviewed changes

custom_connectors/oauth2/bim_360.rb

    
                        "#{version_url}/exports/#{input['export_id']}")

                      project_id = input['project_id'].split('.').last

                      get("/bim360/docs/v1/projects/#{project_id}/versions/" \

                        "#{version_url}/exports/#{input['export_id']}").

Contributor

svchandra Sep 9, 2019

Convert all three in to one merge operation, there are other e.g.

          merge({ hub_id: input['hub_id'] }).
          merge({ project_id: input['project_id'] }).
          merge({ item_id: input['item_id'] })

svchandra reviewed

View reviewed changes

custom_connectors/oauth2/bim_360.rb Outdated

    
            @@ -2671,7 +1758,7 @@
          
                      [

                        {

                          name: 'hub_id',

                          label: 'Hub name',

                          label: 'Hub Name',

Contributor

svchandra Sep 9, 2019

Update label as

label: 'Hub name',
``

svchandra reviewed

View reviewed changes

custom_connectors/oauth2/bim_360.rb Outdated

    
            @@ -2687,7 +1774,7 @@
          
                        },

                        {

                          name: 'project_id',

                          label: 'Project name',

                          label: 'Project Name',

Contributor

svchandra Sep 9, 2019

Update label as```
label: 'Project name',

svchandra reviewed

View reviewed changes

custom_connectors/oauth2/bim_360.rb Outdated

    
            @@ -2721,7 +1807,7 @@
          
                            hint: 'Use Folder ID'

                          } },

                        { name: 'item_id',

                          label: 'File name',

                          label: 'File Name',

Contributor

svchandra Sep 9, 2019

Update label as

label: 'File name',

svchandra reviewed

View reviewed changes

custom_connectors/oauth2/bim_360.rb Outdated

    
                    config_fields: [

                      {

                        name: 'hub_id',

                        label: 'Hub name',

                        label: 'Hub Name',

Contributor

svchandra Sep 9, 2019

Update label as

label: 'Hub name',

svchandra reviewed

View reviewed changes

custom_connectors/oauth2/bim_360.rb Outdated

    
            @@ -2778,7 +1874,7 @@
          
                      },

                      {

                        name: 'project_id',

                        label: 'Project name',

                        label: 'Project Name',

Contributor

svchandra Sep 9, 2019

Update label as

label: 'Project name',

svchandra reviewed

View reviewed changes

custom_connectors/oauth2/bim_360.rb Outdated

    
            @@ -2814,35 +1910,48 @@
          
                    ],

                    input_fields: lambda do |_object_definitions|

                      [

                        { name: 'file_name', optional: false,

                        { name: 'file_name', optional: false, label: 'File Name',

Contributor

svchandra Sep 9, 2019

Update label as

label: 'File Name',

You can ignore as well, workato derives labels from name field.

svchandra reviewed

View reviewed changes

custom_connectors/oauth2/bim_360.rb Outdated

    
                    },

                    input_fields: lambda do |_object_definitions|

                      [

                        {

                          name: 'hub_id',

                          label: 'Hub name',

                          label: 'Hub Name',

Contributor

svchandra Sep 9, 2019

Update label as

label: 'Hub name'

svchandra reviewed

View reviewed changes

custom_connectors/oauth2/bim_360.rb Outdated

    
            @@ -3131,7 +2103,7 @@
          
                        },

                        {

                          name: 'project_id',

                          label: 'Project name',

                          label: 'Project Name',

Contributor

svchandra Sep 9, 2019

Update label as

label: 'Project name',

svchandra reviewed

View reviewed changes

custom_connectors/oauth2/bim_360.rb Outdated

    
                    },

                    input_fields: lambda do |_object_definitions|

                      [

                        {

                          name: 'hub_id',

                          label: 'Hub name',

                          label: 'Hub Name',

Contributor

svchandra Sep 9, 2019

Update label

label: 'Hub name',

svchandra reviewed

View reviewed changes

custom_connectors/oauth2/bim_360.rb Outdated

    
            @@ -3264,7 +2228,7 @@
          
                        },

                        {

                          name: 'project_id',

                          label: 'Project name',

                          label: 'Project Name',

Contributor

svchandra Sep 9, 2019

Update label as

label: 'Project name',

svchandra reviewed

View reviewed changes

custom_connectors/oauth2/bim_360.rb

    
            @@ -3324,22 +2289,27 @@
          
                                     'filter[type]=items&filter[lastModifiedTimeRollup]-ge=' \

                                     "#{last_modified_time}&" \

                                     "page[limit]=#{limit}&page[skip]=#{skip}"

                                   get("/data/v1/projects/#{project_id}/folders/" \

                                     "#{folder_id}/contents", query_params)

                                   get("/data/v1/projects/#{input['project_id']}/folders/" \

Contributor

svchandra Sep 9, 2019

you can use project_id field instead of input['project_id']

Author

sophatsam Sep 9, 2019

this is where we were seeing issues where the project_id is cached from another trigger and was not polling from the project specified in the input. we're using input['project_uid'] to make sure we're polling from the project specified in the input instead of the cached one.

svchandra reviewed

View reviewed changes

custom_connectors/oauth2/bim_360.rb

    
                                   get("/data/v1/projects/#{project_id}/folders/" \

                                     "#{folder_id}/contents", query_params)

                                   get("/data/v1/projects/#{input['project_id']}/folders/" \

                                     "#{input['folder_id']}/contents", query_params)

Contributor

svchandra Sep 9, 2019

you can use folder_id field instead of input['folder_id']

Author

sophatsam Sep 9, 2019

same comment as above. this ensures we're looking at the folder specified in the input instead of the cached value.

svchandra reviewed

View reviewed changes

custom_connectors/oauth2/bim_360.rb

    
                      project_id = closure&.[]('project_id') || input['project_id']

                      container_id = closure&.[]('container_id') ||

                                     get("/project/v1/hubs/#{input['hub_id']}" \

                                         "/projects/#{project_id}")&.

                                         "/projects/#{input['project_id']}")&.

Contributor

svchandra Sep 9, 2019 •

edited

Loading

you can use project_id field instead of input['project_id']
is there any issue to switch from the project_id?

Author

sophatsam Sep 9, 2019

same comment as above. this ensures we're looking at the folder specified in the input instead of the cached value.

svchandra reviewed

View reviewed changes

Contributor

svchandra left a comment

@sophatsam I updated the PR, please fix the changes.

svchandra assigned sophatsam


          update connector based on comments from Chandra

51664f7

Author

sophatsam commented Sep 9, 2019

@svchandra I have pushed the latest commit based on the changes you recommended, with the exception of the last 3 comments where i provided a response comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet