fix: Group notifications older then 2 days by date #22212
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace broad time groups (Older than 2 days) with specific dates - Show calendar dates like 'December 15' for better timeline readability - Maintain 'Today'/'Yesterday' labels for consistency - Use localized date formatting with DateFormat.getDateInstance()
timurgilfanov
force-pushed
the
issue/21191-fix-notification-day-separators
branch
from
8791fc1 to
d167720
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In Jetpack app Notifications older then two days stays in one group and it's hard to separate them. To do so, I group such items by date using data as the header of the group. I used localized date formatting with DateFormat.getDateInstance().
I can't handle testing because have "Enable Jetpack" message on notification screen. I set up temporary site with jurassic.ninja with Jetpack Enabled. Down the enable Jetpack flow in app I stuck at the step with log in step:
I confirmed my emain on WordPress.com but flow doesn't go forward.
Also, I didn't find the way to test notifications list UI with prepopulated data localy.
Testing instructions
Someone need to test it against data source that generate notifications older then 2 days, since there are no documentation to work with Jetpack-speciefic issues:
Originally posted by @nbradbury in #21191