-
Notifications
You must be signed in to change notification settings - Fork 121
[Woo POS][Local Catalog] Catalog settings #16368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
joshheald
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this – the only issue is that the button should have a loading spinner on it, like it used to – could you take a look at that please?
| await viewModel.refreshCatalog() | ||
| } | ||
| }, | ||
| buttonStyle: .primary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The button should have a loading spinner on it...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Fixed: 2f73a6d

Closes WOOMOB-1504
Description
This PR updates the local catalog settings to the updated designs in WOOMOB-1504
Test Steps
I believe we have a miss-match on the toggle and button alignment between the buttons here (aligned to the subtitle of the card) and in other settings (aligned to the center of the card). I asked Wagner in Figma to understand if this is on purpose or not. I can keep this one open till we have an update, otherwise happy to update it to your preferenceConfirmed that are center-aligned: qKAWGmvUsvfnW0Z4CssJHe?node-id=6641-6282&m=dev#1520919842
Screenshots