Skip to content

Conversation

@iamgabrielma
Copy link
Contributor

@iamgabrielma iamgabrielma commented Nov 19, 2025

Closes WOOMOB-1504

Description

This PR updates the local catalog settings to the updated designs in WOOMOB-1504

Test Steps

  • Open POS > Settings > Local catalog
  • Observe that the designs match the proposal

I believe we have a miss-match on the toggle and button alignment between the buttons here (aligned to the subtitle of the card) and in other settings (aligned to the center of the card). I asked Wagner in Figma to understand if this is on purpose or not. I can keep this one open till we have an update, otherwise happy to update it to your preference

Confirmed that are center-aligned: qKAWGmvUsvfnW0Z4CssJHe?node-id=6641-6282&m=dev#1520919842

Screenshots

Light Dark
Simulator Screenshot - iPad (A16) - Tests - 2025-11-19 at 16 28 55 Simulator Screenshot - iPad (A16) - Tests - 2025-11-19 at 16 29 00

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 19, 2025

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16368-2f73a6d
Version23.7
Bundle IDcom.automattic.alpha.woocommerce
Commit2f73a6d
Installation URL1f50ik6i2b0fg
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@iamgabrielma iamgabrielma added type: task An internally driven task. feature: POS labels Nov 19, 2025
@iamgabrielma iamgabrielma added this to the 23.8 milestone Nov 19, 2025
@iamgabrielma iamgabrielma marked this pull request as ready for review November 19, 2025 09:31
@joshheald joshheald self-assigned this Nov 20, 2025
Copy link
Contributor

@joshheald joshheald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this – the only issue is that the button should have a loading spinner on it, like it used to – could you take a look at that please?

await viewModel.refreshCatalog()
}
},
buttonStyle: .primary
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The button should have a loading spinner on it...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Fixed: 2f73a6d

@iamgabrielma iamgabrielma merged commit 89f1add into trunk Nov 21, 2025
14 checks passed
@iamgabrielma iamgabrielma deleted the task/woomob-1504-catalog-settings branch November 21, 2025 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: POS type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants