[Woo POS][App Listings] POS ASC screenshots #16355

iamgabrielma · 2025-11-14T04:56:38Z

Description

This PR adds UI tests for POS in WooCommerceScreenshots target. These screenshots will later be used by fastlane to be uploaded to ASC. We're looking into 3 screenshots:

Dashboard view with 2 items in cart
Totals/Payment view
Payment Success view

Feedback

I'd like specific feedback on 2 items:

We didn't have any infrastructure for this screenshots, and I'm not positive that having these mocks in the WooCommerce target is the best place, but otherwise are hard to inject in order to actually mock the flows we need for the screenshots. Thoughts?
In commit and commit I had to modify when we trigger item loading, since onChange only fires on value changes and not initial values, when passing mocked data into the view this wasn't being trigger as was already available from the get go. Do you see any issue with this? I haven't, but I'm not happy changing implementation for a test.

Test Steps

Create a tools.fastlane folder in your machine if you don't have one yet, in the path: {your machine}/Library/Caches/
Switch the target to WooCommerceScreenshots and run the testScreenshots() test
You should see tests succeeding.
In {your machine}/Library/Caches/tools.fastlane/screenshots you should see the artifacts from the screenshot testing, confirm that pos-dashboard.png, pos-payment.png, and pos-success.png are there.

Screenshots

Dashboard	Payment	Success

dangermattic · 2025-11-14T04:57:09Z

	1 Warning
⚠️	This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

wpmobilebot · 2025-11-14T05:06:09Z

📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce iOS Prototype
	Build Number	`pr16355-36d431f`
	Version	`23.7`
	Bundle ID	`com.automattic.alpha.woocommerce`
	Commit	`36d431f`
	Installation URL	7b6avh5uvp96o

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

Without bypassing eligibility checks like remote FF flag or WC versions, we’ll land in the POS ineligible case and display the error view on loading the POS tab

If we don’t handle this action in the mock, the continuation to check the firmware status never returns from `CardPresentPaymentsService.createUpdateStatePublisher`, so we’re unable to load POS fully

onChange only fires on value changes, not initial values, so when passing mocked data into the view this was only loading 10% of the times. eligibility was already .eligible and the onChange never fired

`cardReaderViewLayout` will not pass the guard despite `posModel.orderState` and `posModel.cardReaderConnectionStatus` returning the expected values if we just pass mocked products to the order, we need to pass order items as well so the `collectCardPayment` call in `PointOfSaleAggregateModel` passes the guard that checks that order items total are not zero.

…OB-1644-pos-app-listing-screenshots # Conflicts: # Modules/Sources/Yosemite/Model/Mocks/ActionHandlers/MockAppSettingsActionHandler.swift

Determines which provider to use, mock item provider for screenshot tests , or default PointOfSaleItemService

we only trigger item load when onChange value changed to be .eligible, however, if eligibility was already .eligible when view appeared (like with mocked data, as is instant), onChange never fired which would make items to never load

for some reason is ignoring `periphery:ignore:all`

joshheald · 2025-11-20T19:03:47Z

In commit and commit I had to modify when we trigger item loading, since onChange only fires on value changes and not initial values, when passing mocked data into the view this wasn't being trigger as was already available from the get go. Do you see any issue with this? I haven't, but I'm not happy changing implementation for a test.

No issues with this. It's the common pattern, and the mocked data probably just exposed a (slightly theoretical) bug.

joshheald

Works as you mention... some suggestions inline

joshheald · 2025-11-20T19:54:52Z

WooCommerce/Classes/POS/TabBar/POSTabCoordinator.swift

+                if ProcessConfiguration.shouldBypassPOSOrderSyncing {
+                    orderService = POSOrderServiceScreenshotMock(currency: currencySettings.currencyCode.rawValue)


Yeah, I don't love this either.

Simple improvement – wrap it in an #if debug as well somehow?

A better (but much trickier) fix might be to set something up like the UITests use, where we mock the network rather than the service...

You could try making a factory protocol for making all this stuff, then at least we could do the ProcessConfiguration check once when creating the factory – either pass in a POSScreenshotsDependencyFactory or POSDependencyFactory – but until we have more mocked dependencies, it's probably over the top.

Best would be if we had a dependency injection framework, where we could swap these components out at will for the whole system. But Stores is the closest thing we have to that, doesn't work with async, and adding one that does is way out of scope.

Sorry, I don't have any particularly bright ideas on this one.

Thanks for sharing you thoughts! I'm not sure if we'll be adding further UI tests or keep them as a one-off for these ASC screenshots. For the time being I've logged this in WOOMOB-1760

Each time we run the scan it figures out a new badge of warnings from the UI test target, this should cover them all

iamgabrielma added 4 commits November 13, 2025 15:43

fix crash on screenshot target due to unhandled action dispatch

da7ed1e

remove unused result warning

9b8f037

Handle actions when opening POS to avoid crash (2)

a87c928

make compile and navigation to POS tab

3838c8f

iamgabrielma added 24 commits November 14, 2025 12:28

make test POS screenshot

e986446

add bypass-pos-eligibility-checks flag for UI tests

f4df262

Without bypassing eligibility checks like remote FF flag or WC versions, we’ll land in the POS ineligible case and display the error view on loading the POS tab

bypass POS product loading got UI test, use mocked data

9e772b1

load mocked product image sources

37d4772

allow taking landscape screenshots

96c1b13

simulate no firmware updates for ui screenshots

54d007b

If we don’t handle this action in the mock, the continuation to check the firmware status never returns from `CardPresentPaymentsService.createUpdateStatePublisher`, so we’re unable to load POS fully

add product to cart

76d7bf1

add multiple products

fb82efd

checkout cart and screenshot

0efe5e6

bypass pos order syncing for screenshot

2bff2c2

fix race condition when loading products

b594e99

onChange only fires on value changes, not initial values, so when passing mocked data into the view this was only loading 10% of the times. eligibility was already .eligible and the onChange never fired

process payment and make screenshot of success UI

5d3a5a9

Merge branch 'task/WOOMOB-1640-post-app-listings-meta' into task/WOOM…

a747986

…OB-1644-pos-app-listing-screenshots # Conflicts: # Modules/Sources/Yosemite/Model/Mocks/ActionHandlers/MockAppSettingsActionHandler.swift

inject mock item provider when needed

75ad416

Determines which provider to use, mock item provider for screenshot tests , or default PointOfSaleItemService

make test pass

0803253

remove comment

3dd788f

move CardPresentPaymentServiceScreenshotMock

3275559

extract mocks to their own directory

0881b91

log error if dependency not provided

4038037

rename

669be56

refactor, move oldvalue to inside onChange

f614aa1

we only trigger item load when onChange value changed to be .eligible, however, if eligibility was already .eligible when view appeared (like with mocked data, as is instant), onChange never fired which would make items to never load

lint and periphery

f16c5df

more periphery

4c90a91

for some reason is ignoring `periphery:ignore:all`

iamgabrielma marked this pull request as ready for review November 20, 2025 09:09

iamgabrielma added type: task An internally driven task. feature: POS labels Nov 20, 2025

iamgabrielma added this to the 23.8 milestone Nov 20, 2025

iamgabrielma requested a review from joshheald November 20, 2025 09:11

joshheald self-assigned this Nov 20, 2025

joshheald approved these changes Nov 20, 2025

View reviewed changes

Base automatically changed from task/WOOMOB-1640-post-app-listings-meta to trunk November 21, 2025 01:11

periphery again

36d431f

Each time we run the scan it figures out a new badge of warnings from the UI test target, this should cover them all

iamgabrielma enabled auto-merge November 21, 2025 03:48

iamgabrielma merged commit dd2f59c into trunk Nov 21, 2025
14 checks passed

iamgabrielma deleted the task/WOOMOB-1644-pos-app-listing-screenshots branch November 21, 2025 04:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Woo POS][App Listings] POS ASC screenshots #16355

[Woo POS][App Listings] POS ASC screenshots #16355

Uh oh!

iamgabrielma commented Nov 14, 2025 •

edited

Loading

Uh oh!

dangermattic commented Nov 14, 2025 •

edited

Loading

Uh oh!

wpmobilebot commented Nov 14, 2025 •

edited

Loading

Uh oh!

joshheald commented Nov 20, 2025

Uh oh!

joshheald left a comment

Uh oh!

joshheald Nov 20, 2025

Uh oh!

iamgabrielma Nov 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

		if ProcessConfiguration.shouldBypassPOSOrderSyncing {
		orderService = POSOrderServiceScreenshotMock(currency: currencySettings.currencyCode.rawValue)

[Woo POS][App Listings] POS ASC screenshots #16355

[Woo POS][App Listings] POS ASC screenshots #16355

Uh oh!

Conversation

iamgabrielma commented Nov 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Feedback

Test Steps

Screenshots

Uh oh!

dangermattic commented Nov 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Nov 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joshheald commented Nov 20, 2025

Uh oh!

joshheald left a comment

Choose a reason for hiding this comment

Uh oh!

joshheald Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

iamgabrielma Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

iamgabrielma commented Nov 14, 2025 •

edited

Loading

dangermattic commented Nov 14, 2025 •

edited

Loading

wpmobilebot commented Nov 14, 2025 •

edited

Loading