Skip to content

Conversation

@mokagio
Copy link
Contributor

@mokagio mokagio commented Oct 7, 2025

Following up on this comment by @jaclync

Description

We should the debug menu entry to toggle Wormholy only in non-public-facing builds. Therefore, we can avoid sending the UI string for localization and save the effort there.

Granted, once the string is localized, there is basically no overhead in having it in the code. Still, from a tidiness point of view, it's neat to remove it.

Testing information

Launch the app on device and verify the menu reads as expected:

IMG_4696
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Oct 7, 2025

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16217-9518748
Version23.4
Bundle IDcom.automattic.alpha.woocommerce
Commit9518748
Installation URL3oa4su2pl5j00
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@mokagio mokagio force-pushed the mokagio/remove-wormholy-localization branch from daa1db3 to 9518748 Compare October 8, 2025 01:01
static let launchWormHolyDebug = NSLocalizedString(
"Launch Wormholy Debug",
comment: "Opens an internal library called Wormholy. Not visible to users."
)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The next time a release runs, we should expect all the "Launch Wormholy Debug" entries in the localization files to be removed.

@mokagio mokagio requested review from a team and jaclync October 8, 2025 01:09
@mokagio mokagio self-assigned this Oct 8, 2025
@mokagio mokagio marked this pull request as ready for review October 8, 2025 01:09
@mokagio mokagio enabled auto-merge October 8, 2025 01:10
@mokagio mokagio added the category: i18n Related to localization/internationalization. label Oct 8, 2025
@mokagio mokagio added this to the 23.5 milestone Oct 8, 2025
Copy link
Contributor

@jaclync jaclync left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for following up with this optimization!

@mokagio mokagio merged commit 40bd31e into trunk Oct 8, 2025
20 of 21 checks passed
@mokagio mokagio deleted the mokagio/remove-wormholy-localization branch October 8, 2025 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: i18n Related to localization/internationalization.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants