[Woo POS] Improve POS tracking conformance #15214
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #15149
Description
This PR improves conformance by splitting POS-related events from shared
CollectOrderPaymentAnalyticsTrackingprotocol to a separatePOSCollectOrderPaymentAnalyticsTrackingprotocol, which holds the POS-specific functions, clearing up the shared protocol to have empty implementations.Changes
POSCollectOrderPaymentAnalyticsTrackingprotocol that contains POS-related eventsPOSCollectOrderPaymentAnalytics, that conforms toPOSCollectOrderPaymentAnalyticsTrackingMockPOSCollectOrderPaymentAnalyticsfor testsTesting information
Question:
When updating the test with the new mock, I've realized the test
removeAllItemsFromCart_when_tapped_then_tracks_eventfails. This is expected since we've updated this functionality on #15200 , however, CI never failed and we could merge this normally. I've removed the test in this PR but I'm wondering if there are differences we should be aware off in POS (eg: iOS17?)RELEASE-NOTES.txtif necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: