-
Notifications
You must be signed in to change notification settings - Fork 135
[WOOMOB-1721] - Small updates to the Booking tab after design review #14973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AdamGrzybkowski
wants to merge
5
commits into
trunk
Choose a base branch
from
issue/WOOMOB-1721_review_fixes
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
Collaborator
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
6dbca0d to
4d2aa21
Compare
- Staff -> Team member - APPOINTMENT DETAILS - BOOKING DETAILS - Remove `price` row
4d2aa21 to
778e77d
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #14973 +/- ##
=========================================
Coverage 38.47% 38.47%
Complexity 10241 10241
=========================================
Files 2155 2155
Lines 122214 122207 -7
Branches 16826 16826
=========================================
- Hits 47017 47015 -2
+ Misses 70426 70420 -6
- Partials 4771 4772 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WOOMOB-1721
Description
Please refer to our doc 13gi1iGagzGHBOzTKfM4I0J4or4RdIJkOZu0qzRdOHR4-gdoc. Each commit should also have enough context to understand the change.
I didn't touch stuff related to attendance and payment status. I want to be sure those are final before changing them in the app.
Test Steps
Go through each change and verify it matches i3 design and the doc description.
Images/gif
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.