Introduce `pos` module #14972

wzieba · 2025-11-14T14:20:53Z

Description

This PR introduces pos module. The goal of introducing one is to improve developer experience of the POS by shortening feedback loops.

Code that is required to be used by both WooCommerce and pos should be placed in common module. You can read more about it internally: p91TBi-dCL-p2

Test Steps

Smoke test the app, review code - especially the part with WooFileLogger injection I commented below.

Images/gif

I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Showcase of mooving a dependency-less class to the new module

So the test is close to implementation

wpmobilebot · 2025-11-14T14:27:31Z

Project manifest changes for WooCommerce-Wear

The following changes in the WooCommerce-Wear's merged AndroidManifest.xml file were detected (build variant: vanillaRelease):

--- ./build/reports/diff_manifest/WooCommerce-Wear/vanillaRelease/base_manifest.txt	2025-11-17 16:26:16.928754284 +0000
+++ ./build/reports/diff_manifest/WooCommerce-Wear/vanillaRelease/head_manifest.txt	2025-11-17 16:26:29.528782826 +0000
@@ -298,12 +298,12 @@
         </receiver>
 
         <activity
+            android:name="androidx.compose.ui.tooling.PreviewActivity"
+            android:exported="true" />
+        <activity
             android:name="com.google.android.gms.common.api.GoogleApiActivity"
             android:exported="false"
-            android:theme="@android:style/Theme.Translucent.NoTitleBar" />
-        <activity
-            android:name="androidx.compose.ui.tooling.PreviewActivity"
-            android:exported="true" /> <!-- 'android:authorities' must be unique in the device, across all apps -->
+            android:theme="@android:style/Theme.Translucent.NoTitleBar" /> <!-- 'android:authorities' must be unique in the device, across all apps -->
         <provider
             android:name="io.sentry.android.core.SentryInitProvider"
             android:authorities="com.woocommerce.android.SentryInitProvider"

Go to https://buildkite.com/automattic/woocommerce-android/builds/33833/canvas?sid=019a929f-1a19-4ab3-9137-ee483caa7274, click on the Artifacts tab and audit the files.

wpmobilebot · 2025-11-14T14:29:44Z

Project dependencies changes

list

+ New Dependencies
org.glassfish:javax.annotation:10.0-b28

tree

-+--- project :libs:commons
-|    +--- org.jetbrains.kotlin:kotlin-stdlib:2.2.21 (*)
-|    \--- org.jetbrains.kotlin:kotlin-parcelize-runtime:2.2.21 (*)
++--- project :libs:pos
+|    +--- org.jetbrains.kotlin:kotlin-stdlib:2.2.21 (*)
+|    +--- project :libs:commons
+|    |    +--- org.jetbrains.kotlin:kotlin-stdlib:2.2.21 (*)
+|    |    +--- androidx.annotation:annotation:1.9.1 (*)
+|    |    +--- org.glassfish:javax.annotation:10.0-b28
+|    |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.10.2 (*)
+|    |    +--- com.automattic.tracks:crashlogging:6.0.6 (*)
+|    |    +--- androidx.lifecycle:lifecycle-process:2.9.4 (*)
+|    |    +--- com.google.dagger:hilt-android:2.57.2
+|    |    |    +--- com.google.dagger:dagger:2.57.2 (*)
+|    |    |    +--- com.google.dagger:dagger-lint-aar:2.57.2
+|    |    |    +--- com.google.dagger:hilt-core:2.57.2
+|    |    |    |    +--- com.google.dagger:dagger:2.57.2 (*)
+|    |    |    |    +--- com.google.code.findbugs:jsr305:3.0.2
+|    |    |    |    +--- jakarta.inject:jakarta.inject-api:2.0.1
+|    |    |    |    \--- javax.inject:javax.inject:1
+|    |    |    +--- com.google.code.findbugs:jsr305:3.0.2
+|    |    |    +--- androidx.activity:activity:1.5.1 -> 1.9.1 (*)
+|    |    |    +--- androidx.annotation:annotation:1.7.1 -> 1.9.1 (*)
+|    |    |    +--- androidx.annotation:annotation-experimental:1.3.1 -> 1.5.0 (*)
+|    |    |    +--- androidx.fragment:fragment:1.5.1 -> 1.8.9 (*)
+|    |    |    +--- androidx.lifecycle:lifecycle-common:2.5.1 -> 2.9.4 (*)
+|    |    |    +--- androidx.lifecycle:lifecycle-viewmodel:2.5.1 -> 2.9.4 (*)
+|    |    |    +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.5.1 -> 2.9.4 (*)
+|    |    |    +--- androidx.savedstate:savedstate:1.2.0 -> 1.3.3 (*)
+|    |    |    +--- javax.inject:javax.inject:1
+|    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:2.1.21 -> 2.2.21 (*)
+|    |    +--- org.wordpress:utils:3.15.0 (*)
+|    |    \--- org.jetbrains.kotlin:kotlin-parcelize-runtime:2.2.21 (*)
+|    \--- com.google.dagger:hilt-android:2.57.2 (*)
-\--- com.google.dagger:hilt-android:2.57.2
-     +--- com.google.dagger:dagger:2.57.2 (*)
-     +--- com.google.dagger:dagger-lint-aar:2.57.2
-     +--- com.google.dagger:hilt-core:2.57.2
-     |    +--- com.google.dagger:dagger:2.57.2 (*)
-     |    +--- com.google.code.findbugs:jsr305:3.0.2
-     |    +--- jakarta.inject:jakarta.inject-api:2.0.1
-     |    \--- javax.inject:javax.inject:1
-     +--- com.google.code.findbugs:jsr305:3.0.2
-     +--- androidx.activity:activity:1.5.1 -> 1.9.1 (*)
-     +--- androidx.annotation:annotation:1.7.1 -> 1.9.1 (*)
-     +--- androidx.annotation:annotation-experimental:1.3.1 -> 1.5.0 (*)
-     +--- androidx.fragment:fragment:1.5.1 -> 1.8.9 (*)
-     +--- androidx.lifecycle:lifecycle-common:2.5.1 -> 2.9.4 (*)
-     +--- androidx.lifecycle:lifecycle-viewmodel:2.5.1 -> 2.9.4 (*)
-     +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.5.1 -> 2.9.4 (*)
-     +--- androidx.savedstate:savedstate:1.2.0 -> 1.3.3 (*)
-     +--- javax.inject:javax.inject:1
-     \--- org.jetbrains.kotlin:kotlin-stdlib:2.1.21 -> 2.2.21 (*)
++--- project :libs:commons (*)
+\--- com.google.dagger:hilt-android:2.57.2 (*)

wpmobilebot · 2025-11-14T14:41:57Z

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce-Wear Android
	Platform	⌚️ Wear OS
	Flavor	Jalapeno
	Build Type	Debug
	Commit	`2fc03f2`
	Direct Download	`woocommerce-wear-prototype-build-pr14972-2fc03f2.apk`

wpmobilebot · 2025-11-14T14:54:56Z

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Platform	📱 Mobile
	Flavor	Jalapeno
	Build Type	Debug
	Commit	`2fc03f2`
	Direct Download	`woocommerce-prototype-build-pr14972-2fc03f2.apk`

@Inject

This fixes the ClassCastException when running WooCommerce tests after moving WooLog to the commons module. Changes: 1. Remove Hilt/KSP plugins from commons module - commons doesn't need to process Hilt annotations itself. The WooCommerce and Wear modules that depend on commons will process any Hilt annotations found in commons (like @Inject on WooFileLogger). 2. Replace EntryPoints.get() pattern with direct injection - Changed WooLog.init() to accept WooFileLogger directly instead of using Context and EntryPoints.get(). This is cleaner and removes the code smell of using EntryPoints for something that can be injected. 3. Update WooCommerce's AppConfigModule to inject WooFileLogger into provideWooLog() and pass it to WooLog.init(). This approach avoids forcing the Wear module to provide dependencies (AppCoroutineScope, CoroutineDispatchers) that it doesn't actually use, since Wear doesn't use WooLog at all. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

wzieba · 2025-11-17T15:30:57Z

libs/commons/src/main/java/com/woocommerce/android/util/WooLog.kt

    private lateinit var fileLogger: WooFileLogger

-    fun init(context: Context) {
+    fun init(fileLogger: WooFileLogger) {


Extra caution: I'm not sure why EntryPoints.get(context, FileLoggerEntryPoint::class.java).fileLogger() was introduced instead of directly passing WooFileLogger. It was added in 41e9dc0 but I couldn't find the reason there on in PR. So I assume, this was just a cosmetic choice to use context + EntryPoints.

So here I refactored it to make it simpler. This also moves injection logic from the commons module, leaving only annotations here.

codecov-commenter · 2025-11-17T15:56:00Z

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 38.47%. Comparing base (d1720fc) to head (2fc03f2).

Files with missing lines	Patch %	Lines
...c/main/java/com/woocommerce/android/util/WooLog.kt	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##              trunk   #14972      +/-   ##
============================================
- Coverage     38.48%   38.47%   -0.01%     
+ Complexity    10240    10239       -1     
============================================
  Files          2155     2156       +1     
  Lines        122167   122258      +91     
  Branches      16807    16812       +5     
============================================
+ Hits          47013    47042      +29     
- Misses        70388    70449      +61     
- Partials       4766     4767       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

samiuelson

LGTM, thanks!

wzieba added 8 commits November 14, 2025 12:02

Add basic pos module configuration

2e1af13

Move WooPosAppUrls to pos module

c0d1e44

Showcase of mooving a dependency-less class to the new module

Move WooLog related classes to common module

e2e0c14

Move reusable test utilities to common's testsFixtures

7214a8c

Move LogFileWriterTest to commons

db1caa6

So the test is close to implementation

Move WooFileLoggerTest to commons

10b727d

So the test is close to implementation

Move WooPosLogWrapper to pos module

4a79b34

Use already defined javax dependency

15e2216

Merge branch 'trunk' into introduce_pos_module

81ef48c

Add pos test task dependency on jacocoTestReport

3864225

wzieba added the category: performance Related to performance such as slow loading. label Nov 14, 2025

wzieba added this to the 23.8 milestone Nov 14, 2025

wzieba and others added 2 commits November 14, 2025 17:53

Merge branch 'trunk' into introduce_pos_module

0fd2bc2

wzieba force-pushed the introduce_pos_module branch from db5a86b to c87d136 Compare November 17, 2025 15:20

wzieba commented Nov 17, 2025

View reviewed changes

Merge branch 'trunk' into introduce_pos_module

2fc03f2

wzieba marked this pull request as ready for review November 18, 2025 08:03

wzieba requested a review from a team as a code owner November 18, 2025 08:03

wzieba requested review from samiuelson and removed request for a team November 18, 2025 08:03

samiuelson self-assigned this Nov 19, 2025

samiuelson approved these changes Nov 19, 2025

View reviewed changes

samiuelson merged commit 0680aa0 into trunk Nov 19, 2025
19 checks passed

samiuelson deleted the introduce_pos_module branch November 19, 2025 17:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Introduce `pos` module #14972

Introduce `pos` module #14972

Uh oh!

wzieba commented Nov 14, 2025 •

edited

Loading

Uh oh!

wpmobilebot commented Nov 14, 2025 •

edited

Loading

Uh oh!

wpmobilebot commented Nov 14, 2025

Uh oh!

wpmobilebot commented Nov 14, 2025 •

edited

Loading

Uh oh!

wpmobilebot commented Nov 14, 2025 •

edited

Loading

Uh oh!

wzieba Nov 17, 2025

Uh oh!

codecov-commenter commented Nov 17, 2025 •

edited

Loading

Uh oh!

samiuelson left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Introduce pos module #14972

Introduce pos module #14972

Uh oh!

Conversation

wzieba commented Nov 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Test Steps

Images/gif

Uh oh!

wpmobilebot commented Nov 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Project manifest changes for WooCommerce-Wear

Uh oh!

wpmobilebot commented Nov 14, 2025

Project dependencies changes

Uh oh!

wpmobilebot commented Nov 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Nov 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wzieba Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

codecov-commenter commented Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

samiuelson left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Introduce `pos` module #14972

Introduce `pos` module #14972

wzieba commented Nov 14, 2025 •

edited

Loading

wpmobilebot commented Nov 14, 2025 •

edited

Loading

wpmobilebot commented Nov 14, 2025 •

edited

Loading

wpmobilebot commented Nov 14, 2025 •

edited

Loading

codecov-commenter commented Nov 17, 2025 •

edited

Loading