[WOOMOB-1648] Add tablet screenshot infrastructure for Woo POS #14948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Generated by 🚫 Danger |
Collaborator
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
Collaborator
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Base automatically changed from
woomob-1649-woo-posapp-listings-add-a-test-to-open-the-pos-and-make-a
to
trunk
November 13, 2025 14:25
kidinov
commented
Nov 18, 2025
| @@ -1 +1 @@ | |||
| Manage orders, get sales notifications, and view key metrics — wherever you are. No newline at end of file | |||
| Manage orders, get notifications, view metrics, and accept in-person payments. No newline at end of file | |||
Contributor
Author
There was a problem hiding this comment.
@iamgabrielma there is also "short description" on android which I updated like that. Wdyt?
There was a problem hiding this comment.
Interesting! I'm fine with it, but could you ping Adam Maid (I don't see a github handler) in the P2 to confirm the copy? We might miss something as non-natives.
kidinov
commented
Nov 18, 2025
| Collect physical payments using WooCommerce In-Person Payments and a card reader. Start a new order - or find an existing one that’s pending payment - and collect payment using the card reader or a digital wallet, such as Google Pay. | ||
| Collect physical payments using WooCommerce In-Person Payments and a card reader (available in the US, UK, and Canada), Tap to Pay, or a digital wallet, such as Apple Pay. Start a new order — or find an existing one that's pending payment – then seamlessly accept payment. | ||
|
|
||
| Go from clicks to bricks |
Contributor
Author
There was a problem hiding this comment.
@iamgabrielma I added a new section to the description right after the IPP section. Is this what you meant?
…t-to-the-ci-configuration-to
| .append('en-US') | ||
| end | ||
|
|
||
| UI.message("Clearing previous POS screenshots...") |
Collaborator
There was a problem hiding this comment.
| 🚫 | Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols. |
| end | ||
|
|
||
| UI.message("Clearing previous POS screenshots...") | ||
| sh("rm -f ../fastlane/screenshots/raw/*-pos-*") |
Collaborator
There was a problem hiding this comment.
| 🚫 | Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols. |
| UI.message("Clearing previous POS screenshots...") | ||
| sh("rm -f ../fastlane/screenshots/raw/*-pos-*") | ||
|
|
||
| UI.message("Building APKs...") |
Collaborator
There was a problem hiding this comment.
| 🚫 | Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols. |
Collaborator
🤖 Test Failure AnalysisYour tests failed. Claude has analyzed the failures - check the annotation for details. |
kidinov
added
the
status: do not merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WOOMOB-1648
Do not merge because the texts are still not final and I have a couple of questions about this PR
Description
Adds infrastructure for capturing screenshots on tablets for Woo POS and updates Play Store metadata to highlight POS features.
Changes:
LocaleTestRuleand landscape orientation locking toWooPosScreenshotTesttake_pos_screenshotsFastlane lane for capturing tablet screenshots across all supported localesTest Steps
bundle exec fastlane take_pos_screenshotsfastlane/screenshots/raw/{locale}/images/phoneScreenshots/1-pos-home-light.png,2-pos-totals-light.png,3-pos-payment-success-light.pngfor each localeQuestions
@irfano and @ianmaia (asking you just by checking git history)
Q1: Screenshot workflow
Screenshots are taken locally and need to be manually uploaded to Google Play Console. Is this the correct workflow?
Q2: Metadata translations
The en-US metadata files will be translated automatically during the release process via GlotPress. We don't need to provide translations now. Can someone confirm this is correct?
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.