This repository was archived by the owner on Oct 4, 2019. It is now read-only.
Add data endpoints for getting currencies #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… their name and symbol.
claudiosanches
approved these changes
Jun 5, 2017
Contributor
claudiosanches
left a comment
claudiosanches
left a comment
There was a problem hiding this comment.
Looks good and should now solve all use cases.
Great work!
| ), | ||
| 'schema' => array( $this, 'get_public_item_schema' ), | ||
| ) ); | ||
| register_rest_route( $this->namespace, '/' . $this->rest_base . '/(?P<currency>[\w-]+)', array( |
Contributor
There was a problem hiding this comment.
Looks good and this is just a note, but this is a regex, so it's possible to limit to only 3 characters and should make easy for current.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds endpoints for getting a list of supported currencies, along with their name and symbol broken out. Includes tests.
It implements three new endpoints:
/wc/v3/data/currencieswhich returns a list of all supported currency codes, their currency name, and symbol as separate fields./wc/v3/data/currencies/$currencywhich returns a currency code, name, and symbol for a specific currency./wc/v3/data/currencies/currentwhich returns a currency code, name, and symbol, for the currency that is currently being used on the site.To Test:
phpunitand make sure all tests pass./wc/v3/data/currencies/using postman or another tool and look at responses.Fixes #2.
See previous PR/discussion at #8.