Skip to content

FIX #835: null mNotification #862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2022
Merged

FIX #835: null mNotification #862

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/android/app/src/main/java/com/wix/reactnativenotifications/RNNotificationsModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,10 @@ public void getInitialNotification(final Promise promise) {
return;
}

InitialNotificationHolder.getInstance().clear();
result = Arguments.fromBundle(notification.asBundle());
InitialNotificationHolder.getInstance().clear();
} catch (NullPointerException e) {
Log.e(LOGTAG, "getInitialNotification: Null pointer exception");
} finally {
promise.resolve(result);
}
Expand Down
2 changes: 1 addition & 1 deletion ...roid/app/src/main/java/com/wix/reactnativenotifications/core/ReactAppLifecycleFacade.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public synchronized boolean isReactInitialized() {
return false;
}

return mReactContext.hasActiveCatalystInstance();
return mReactContext.hasActiveReactInstance();
}

@Override
Expand Down