Fixing white square icon and annotation error #379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 19, 2019 15:32
…ion icons that do not follow the notification icon Standard. Should be a non breaking change as the fall back should pull the application icon if it's not defined
…rong thing. We should be importing NonNull as importing Nullable causes a build error. The RN 60 flavor of the file is importing the NonNull
Forgot one more place to update the file name
yogevbd
approved these changes
Sep 19, 2019
|
@yogevbd thank you for approving! any ETA on when this can be merged in and possibly published? I ask because this is a current blocker for my team at the moment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, the package has an error under RN59 where the wrong annotation is being imported. This is causing my build to break and can only assume many others who have not upgraded to 60.
The package also has an issue where the app icon is a white square. This is because the notification builder is setting the small icon to be the same as the app icon and in most cases the app icon does not follow the same design requirements as the notification icon (White and Transparent only). My change here should be a non breaking change as it still supports the app icon being imported if a notification icon is not defined/provided.