Skip to content

Meta: upgrade webidl2js dependency to v17 #1297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Meta: upgrade webidl2js dependency to v17 #1297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion reference-implementation/lib/ReadableStream-impl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ exports.implementation = class ReadableStreamImpl {
if (underlyingSource === undefined) {
underlyingSource = null;
}
const underlyingSourceDict = UnderlyingSource.convert(underlyingSource);
const underlyingSourceDict = UnderlyingSource.convert(globalObject, underlyingSource);

aos.InitializeReadableStream(this);

Expand Down
2 changes: 1 addition & 1 deletion reference-implementation/lib/TransformStream-impl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ exports.implementation = class TransformStreamImpl {
if (transformer === undefined) {
transformer = null;
}
const transformerDict = Transformer.convert(transformer);
const transformerDict = Transformer.convert(globalObject, transformer);
if ('readableType' in transformerDict) {
throw new RangeError('Invalid readableType specified');
}
Expand Down
2 changes: 1 addition & 1 deletion reference-implementation/lib/WritableStream-impl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ exports.implementation = class WritableStreamImpl {
if (underlyingSink === undefined) {
underlyingSink = null;
}
const underlyingSinkDict = UnderlyingSink.convert(underlyingSink);
const underlyingSinkDict = UnderlyingSink.convert(globalObject, underlyingSink);
if ('type' in underlyingSinkDict) {
throw new RangeError('Invalid type is specified');
}
Expand Down
2 changes: 1 addition & 1 deletion reference-implementation/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"eslint": "^6.8.0",
"minimatch": "^3.0.4",
"opener": "^1.5.1",
"webidl2js": "^16.2.0",
"webidl2js": "^17.1.0",
"wpt-runner": "^5.0.0"
}
}