Make <body topmargin> win over <iframe marginheight> #2489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches Gecko and Edge. Chromium and WebKit copy the marginheight attribute from `<iframe>` to the child document's `<body>`, which then takes precedence over `topmargin`, but copying the attribute is non-conforming. Fixes #2484.
annevk
added
the
needs tests
annevk
approved these changes
Mar 31, 2017
zcorpan
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 31, 2017
zcorpan
removed
the
needs tests
domenic
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 17, 2017
inikulin
pushed a commit
to HTMLParseErrorWG/html
that referenced
this pull request
May 9, 2017
This matches Gecko and Edge. Chromium and WebKit copy the marginheight attribute from <iframe> to the child document's <body>, which then takes precedence over topmargin, but copying the attribute is non-conforming. Fixes whatwg#2484.
inikulin
pushed a commit
to HTMLParseErrorWG/html
that referenced
this pull request
May 9, 2017
This matches Gecko and Edge. Chromium and WebKit copy the marginheight attribute from <iframe> to the child document's <body>, which then takes precedence over topmargin, but copying the attribute is non-conforming. Fixes whatwg#2484.
alice
pushed a commit
to alice/html
that referenced
this pull request
Jan 8, 2019
This matches Gecko and Edge. Chromium and WebKit copy the marginheight attribute from <iframe> to the child document's <body>, which then takes precedence over topmargin, but copying the attribute is non-conforming. Fixes whatwg#2484.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches Gecko and Edge. Chromium and WebKit copy the
marginheight attribute from
<iframe>to the child document's<body>, which then takes precedence overtopmargin, but copyingthe attribute is non-conforming.
Fixes #2484.