Skip to content

Address review feedback on language override of navigator.language/s. #11922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −6
Open

Address review feedback on language override of navigator.language/s. #11922

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions source
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125536,7 +125536,7 @@ interface <dfn interface>Navigator</dfn> {
<li>Let <var>emulatedLanguage</var> be the <span>WebDriver BiDi emulated language</span> for
<span>this</span>'s <span>relevant settings object</span></li>

<li>If <var>emulatedLanguage</var> is not null, return <var>emulatedLanguage</var>.</li>
<li>If <var>emulatedLanguage</var> is not null, then return <var>emulatedLanguage</var>.</li>

<li>Return a valid BCP 47 language tag representing either <span>a plausible language</span> or
the user's most preferred language. <ref>BCP47</ref>.</li>
Expand All @@ -125551,16 +125551,15 @@ interface <dfn interface>Navigator</dfn> {
<li>Let <var>emulatedLanguage</var> be the <span>WebDriver BiDi emulated language</span> for
<span>this</span>'s <span>relevant settings object</span></li>

<li>If <var>emulatedLanguage</var> is not null, return a <span>frozen array</span> containing
<li>If <var>emulatedLanguage</var> is not null, then return a <span>frozen array</span> containing
<var>emulatedLanguage</var>.</li>

<li>Return a <span>frozen array</span> of valid BCP 47 language tags representing either one or
more <span data-x="a plausible language">plausible languages</span>, or the user's preferred
languages, ordered by preference with the most preferred language first. <ref>BCP47</ref></li>
languages, ordered by preference with the most preferred language first. The same object must be
returned until the user agent needs to return different values, or values in a different order,
or <var>emulatedLanguage</var> is updated. <ref>BCP47</ref></li>
Copy link
Member

@annevk annevk Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To do this properly we have to store the object we intend to return on Navigator in an associated concept of sorts. And then each time we run this algorithm we see if any of the values changed, and if not, we return the cached object. And if they have changed, we update the cached object and then return it.

</ol>

<p>The same object must be returned until the user agent needs to return different values, or
values in a different order, or <var>emulatedLanguage</var> is updated.</p>
</div>

<div algorithm>
Expand Down