Skip to content

Conversation

@adrianhopebailie
Copy link
Contributor

I submitted #1612 to update verifyClient because I was unaware of #377 (comment)

This discussion has been going on since 2014 so I figured it would be useful to update some of the examples and docs to save someone else from making the mistake I did 😄

This change:

  • Updates the README with a client auth example
  • Updates the existing express-sessions example to stop using verifyClient
  • Put notes in the docs to discourage the use of verifyClient

@lpinca
Copy link
Member

lpinca commented Aug 4, 2019

Thank you for this, rubber stamp LGTM. There are a few nits I would like to address. I will specify them later.

Co-Authored-By: Luigi Pinca <[email protected]>
@lpinca lpinca merged commit 0a61236 into websockets:master Aug 4, 2019
@lpinca
Copy link
Member

lpinca commented Aug 4, 2019

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants