Skip to content

Remove Seek requirement for some writers #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2025
Merged

Remove Seek requirement for some writers #743

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions media/src/io/h264_writer/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#[cfg(test)]
mod h264_writer_test;

use std::io::{Seek, Write};
use std::io::Write;

use rtp::codecs::h264::H264Packet;
use rtp::packetizer::Depacketizer;
Expand Down Expand Up @@ -29,13 +29,13 @@ fn is_key_frame(data: &[u8]) -> bool {
/// Currently it only supports non-interleaved mode
/// Therefore, only 1-23, 24 (STAP-A), 28 (FU-A) NAL types are allowed.
/// <https://tools.ietf.org/html/rfc6184#section-5.2>
pub struct H264Writer<W: Write + Seek> {
pub struct H264Writer<W: Write> {
writer: W,
has_key_frame: bool,
cached_packet: Option<H264Packet>,
}

impl<W: Write + Seek> H264Writer<W> {
impl<W: Write> H264Writer<W> {
// new initializes a new H264 writer with an io.Writer output
pub fn new(writer: W) -> Self {
H264Writer {
Expand All @@ -46,7 +46,7 @@ impl<W: Write + Seek> H264Writer<W> {
}
}

impl<W: Write + Seek> Writer for H264Writer<W> {
impl<W: Write> Writer for H264Writer<W> {
/// write_rtp adds a new packet and writes the appropriate headers for it
fn write_rtp(&mut self, packet: &rtp::packet::Packet) -> Result<()> {
if packet.payload.is_empty() {
Expand Down
8 changes: 4 additions & 4 deletions media/src/io/ogg_writer/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#[cfg(test)]
mod ogg_writer_test;

use std::io::{BufWriter, Seek, Write};
use std::io::{BufWriter, Write};

use byteorder::{LittleEndian, WriteBytesExt};
use bytes::Bytes;
Expand All @@ -12,7 +12,7 @@ use crate::io::ogg_reader::*;
use crate::io::Writer;

/// OggWriter is used to take RTP packets and write them to an OGG on disk
pub struct OggWriter<W: Write + Seek> {
pub struct OggWriter<W: Write> {
writer: W,
sample_rate: u32,
channel_count: u8,
Expand All @@ -25,7 +25,7 @@ pub struct OggWriter<W: Write + Seek> {
last_payload: Bytes,
}

impl<W: Write + Seek> OggWriter<W> {
impl<W: Write> OggWriter<W> {
/// new initialize a new OGG Opus writer with an io.Writer output
pub fn new(writer: W, sample_rate: u32, channel_count: u8) -> Result<Self> {
let mut w = OggWriter {
Expand Down Expand Up @@ -166,7 +166,7 @@ impl<W: Write + Seek> OggWriter<W> {
}
}

impl<W: Write + Seek> Writer for OggWriter<W> {
impl<W: Write> Writer for OggWriter<W> {
/// write_rtp adds a new packet and writes the appropriate headers for it
fn write_rtp(&mut self, packet: &rtp::packet::Packet) -> Result<()> {
if packet.payload.is_empty() {
Expand Down
Loading