Skip to content

Close SSE empty line type loophole #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Close SSE empty line type loophole #38

wants to merge 1 commit into from
+1 −1

Conversation

@rapropos
Copy link
Contributor

@rapropos rapropos commented Aug 7, 2025

line?.length === 0 will be falsy even if line is undefined. If the tsc option noUncheckedIndexedAccess is enabled, array dereferences always run the risk of being undefined. Thus, the call to JSON.parse will generate errors. Changing the emptiness test to !line || line.length === 0 closes off this possibility and makes the JSON.parse call happy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexanderKolberg AlexanderKolberg Awaiting requested review from AlexanderKolberg

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@rapropos