Skip to content

Conversation

@hai-x
Copy link
Member

@hai-x hai-x commented Jun 10, 2025

Fixes webpack/terser-webpack-plugin#589.

We should generate the column mapping that points to no source(i.e. sourceIndex < 0) in ConcatSource.

We will validate it in createFullMappingsSerializer to ensure it is valid when followed by an active mapping.

@codecov
Copy link

codecov bot commented Jun 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.24%. Comparing base (6af577c) to head (0b913d7).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #171   +/-   ##
=======================================
  Coverage   93.24%   93.24%           
=======================================
  Files          25       25           
  Lines        1866     1866           
  Branches      595      596    +1     
=======================================
  Hits         1740     1740           
  Misses        117      117           
  Partials        9        9           
Flag Coverage Δ
integration 93.24% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's fix linting and we can merge

@alexander-akait alexander-akait merged commit b19b923 into main Jun 20, 2025
28 checks passed
@alexander-akait alexander-akait deleted the fix-skip-column-map branch June 20, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Source Map is inorrect when enable extractComments.banner of terser-webpack-plugin

3 participants