refactor: move https normalization #3331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anshumanv
requested review from
alexander-akait,
hiroppy,
knagaitsev and
snitin315
as code owners
Codecov Report
@@ Coverage Diff @@
## master #3331 +/- ##
=======================================
Coverage 95.69% 95.70%
=======================================
Files 34 34
Lines 1279 1280 +1
Branches 368 369 +1
=======================================
+ Hits 1224 1225 +1
Misses 51 51
Partials 4 4
Continue to review full report at Codecov.
|
lib/utils/normalizeOptions.js
Outdated
|
|
||
| if (!options.https.key || !options.https.cert) { | ||
| fakeCert = getCertificate( | ||
| compiler.getInfrastructureLogger('webpack-dev-server') |
Member
There was a problem hiding this comment.
We need assign to this.logger before and use this.logger everywhere
alexander-akait
approved these changes
May 24, 2021
snitin315
approved these changes
May 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Existing
Motivation / Use-Case
We have an option normalizer which deals with option normalization and hence is a better candidate for this computation
Breaking Changes
nope
Additional Info