feat: use server address and fallback to 0.0.0.0 (location.hostname) in createDomain

[ylemkimon]

• This is a bugfix
• This is a feature
• This is a code refactor
• This is a test update
• This is a docs update
• This is a metadata update

For Bugs and Features; did you add new tests?

Covered by existing tests.

Motivation / Use-Case

createDomain is used in two places:

• createSocketUrl: by setting to 0.0.0.0, it uses the location.hostname by default, like the port (fix(cli): use webpack-cli@4 #2845 (comment), fix: use location.port as the client port by default #2850, feat(client): allow sock host to use browser location's host #2859)
• showStatus: this allows setting options.host = undefined and let listen() handle the address binding.

This is required for webpack/webpack-cli#2141.

Breaking Changes

Yes, the client uses the hostname of the current location (location.hostname), by default. To get existing behavior, set the client.host with the hostname you'd like to set to, e.g.:

const server = new Server(compiler, {
  client: {
    host: hostname,
  }
});
server.listen(port, hostname);

Additional Info

[codecov]

Codecov Report

Merging #2869 (c9839d4) into v4 (ecf2fe1) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##               v4    #2869      +/-   ##
==========================================
+ Coverage   92.45%   92.46%   +0.01%     
==========================================
  Files          38       38              
  Lines        1246     1248       +2     
  Branches      326      326              
==========================================
+ Hits         1152     1154       +2     
  Misses         89       89              
  Partials        5        5              

Impacted Files	Coverage Δ
lib/utils/createDomain.js	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecf2fe1...c9839d4. Read the comment docs.

[alexander-akait]

I found breaking change is feature 😄

[alexander-akait]

/cc @hiroppy