Skip to content

chore(standard-version): add .versionrc to hide test's section #2027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2019

Conversation

hiroppy
Copy link
Member

@hiroppy hiroppy commented Jun 14, 2019

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

no

Motivation / Use-Case

we always delete test's section from CHANGELOG.md manually, but it bothers and this change can prevent to rebase to fix CHANGELOG.md.

Breaking Changes

Additional Info

@hiroppy hiroppy requested a review from alexander-akait as a code owner June 14, 2019 02:06
@hiroppy hiroppy changed the title chore(standard-version): add .versionrc to hide tests section chore(standard-version): add .versionrc to hide test's section Jun 14, 2019
@codecov
Copy link

codecov bot commented Jun 14, 2019

Codecov Report

Merging #2027 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2027      +/-   ##
==========================================
- Coverage   92.86%   92.77%   -0.09%     
==========================================
  Files          29       29              
  Lines        1149     1149              
  Branches      327      327              
==========================================
- Hits         1067     1066       -1     
- Misses         78       79       +1     
  Partials        4        4
Impacted Files Coverage Δ
lib/Server.js 92.51% <0%> (-0.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 661f6a2...7ec9af7. Read the comment docs.

@alexander-akait
Copy link
Member

hm, previously standard-release do not generate this stuff, they change logic?

@hiroppy
Copy link
Member Author

hiroppy commented Jun 14, 2019

master

$ npx standard-version --dry-run

✔ bumping version in package.json from 3.7.1 to 3.7.2
✔ bumping version in package-lock.json from 3.7.1 to 3.7.2
✔ outputting changes to CHANGELOG.md

---
### [3.7.2](https://github.com/webpack/webpack-dev-server/compare/v3.7.1...v3.7.2) (2019-06-14)


### Bug Fixes

* **open:** set `wait: false` to run server.close successfully ([#2001](https://github.com/webpack/webpack-dev-server/issues/2001)) ([2b4cb52](https://github.com/we
bpack/webpack-dev-server/commit/2b4cb52))
* **test:** fixed ProvidePlugin.test.js ([#2002](https://github.com/webpack/webpack-dev-server/issues/2002)) ([47453cb](https://github.com/webpack/webpack-dev-serve
r/commit/47453cb))


### Tests

* don't use --runInBand and improve execution performance ([#2007](https://github.com/webpack/webpack-dev-server/issues/2007)) ([4dec6b2](https://github.com/webpack
/webpack-dev-server/commit/4dec6b2)), closes [#2005](https://github.com/webpack/webpack-dev-server/issues/2005)
* **e2e:** make browser close before tests run ([#2018](https://github.com/webpack/webpack-dev-server/issues/2018)) ([f611304](https://github.com/webpack/webpack-de
v-server/commit/f611304))
* **options:** set jest.setTimeout ([#1999](https://github.com/webpack/webpack-dev-server/issues/1999)) ([ce81c69](https://github.com/webpack/webpack-dev-server/com
mit/ce81c69))
* **provide-plugin:** use port variable ([#2008](https://github.com/webpack/webpack-dev-server/issues/2008)) ([39b83c4](https://github.com/webpack/webpack-dev-serve
r/commit/39b83c4))
---

✔ committing package-lock.json and package.json and CHANGELOG.md
✔ tagging release v3.7.2
ℹ Run `git push --follow-tags origin master && npm publish` to publish

this branch

$ npx standard-version --dry-run

✔ bumping version in package.json from 3.7.1 to 3.7.2
✔ bumping version in package-lock.json from 3.7.1 to 3.7.2
✔ outputting changes to CHANGELOG.md

---
### [3.7.2](https://github.com/webpack/webpack-dev-server/compare/v3.7.1...v3.7.2) (2019-06-14)


### Bug Fixes

* **open:** set `wait: false` to run server.close successfully ([#2001](https://github.com/webpack/webpack-dev-server/issues/2001)) ([2b4cb52](https://github.com/we
bpack/webpack-dev-server/commit/2b4cb52))
* **test:** fixed ProvidePlugin.test.js ([#2002](https://github.com/webpack/webpack-dev-server/issues/2002)) ([47453cb](https://github.com/webpack/webpack-dev-serve
r/commit/47453cb))
---

✔ committing package-lock.json and package.json and CHANGELOG.md
✔ tagging release v3.7.2
ℹ Run `git push --follow-tags origin feature/add-versionrc && npm publish` to publish

Test's section is unnecessary.

@alexander-akait
Copy link
Member

Interesting, maybe we should add flag, we need investigate why this behavior was changed

@hiroppy
Copy link
Member Author

hiroppy commented Jun 14, 2019

This is a different behavior of standard-version. So we don't need to investigate about this.
https://github.com/conventional-changelog/standard-version/blob/master/.versionrc

"types": [
{"type":"feat","section":"Features"},
{"type":"fix","section":"Bug Fixes"},
{"type":"test", "hidden": true}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can have extra settings for Features and Bug Fixes and keep only one line for tests

Copy link
Member Author

@hiroppy hiroppy Jun 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, they are required. This library cannot extend the object schema.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, okay, i think we need use this:

{
  "types": [
    {"type":"feat","section":"Features"},
    {"type":"fix","section":"Bug Fixes"},
    {"type":"test","section":"Tests", "hidden": true},
    {"type":"build","section":"Build System", "hidden": true},
    {"type":"ci","hidden":true}
  ]
}

Copy link
Member Author

@hiroppy hiroppy Jun 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? We don't use build and CI. They are unnecessary. I don't know why you want to add these but if you want to add these, we should add chore because we always use it, right?

Copy link
Member

@alexander-akait alexander-akait Jun 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am use ci: and build:, but very rare, it is interesting, why standard-release doesn't generate chore:, but generate test:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway thanks for investigate, it is really very strange

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

np, I made a mistake to forget to retag when I deleted test's section from CHANGELOG.md and rebased.(v3.6.0)

Copy link
Member Author

@hiroppy hiroppy Jun 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway, if we'll use "ci" and "build" in our repo, please add these. I'll merge this pr.

@hiroppy hiroppy merged commit 24a348f into master Jun 17, 2019
@hiroppy hiroppy deleted the feature/add-versionrc branch June 17, 2019 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants