-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
chore(standard-version): add .versionrc to hide test's section #2027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2027 +/- ##
==========================================
- Coverage 92.86% 92.77% -0.09%
==========================================
Files 29 29
Lines 1149 1149
Branches 327 327
==========================================
- Hits 1067 1066 -1
- Misses 78 79 +1
Partials 4 4
Continue to review full report at Codecov.
|
hm, previously standard-release do not generate this stuff, they change logic? |
master
this branch
Test's section is unnecessary. |
Interesting, maybe we should add flag, we need investigate why this behavior was changed |
This is a different behavior of standard-version. So we don't need to investigate about this. |
"types": [ | ||
{"type":"feat","section":"Features"}, | ||
{"type":"fix","section":"Bug Fixes"}, | ||
{"type":"test", "hidden": true} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can have extra settings for Features
and Bug Fixes
and keep only one line for tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, they are required. This library cannot extend the object schema.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm, okay, i think we need use this:
{
"types": [
{"type":"feat","section":"Features"},
{"type":"fix","section":"Bug Fixes"},
{"type":"test","section":"Tests", "hidden": true},
{"type":"build","section":"Build System", "hidden": true},
{"type":"ci","hidden":true}
]
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why? We don't use build and CI. They are unnecessary. I don't know why you want to add these but if you want to add these, we should add chore because we always use it, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i am use ci:
and build:
, but very rare, it is interesting, why standard-release doesn't generate chore:
, but generate test:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyway thanks for investigate, it is really very strange
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
np, I made a mistake to forget to retag when I deleted test's section from CHANGELOG.md and rebased.(v3.6.0)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyway, if we'll use "ci" and "build" in our repo, please add these. I'll merge this pr.
For Bugs and Features; did you add new tests?
no
Motivation / Use-Case
we always delete test's section from CHANGELOG.md manually, but it bothers and this change can prevent to rebase to fix CHANGELOG.md.
Breaking Changes
Additional Info