v3.2.0 Breaks host parameter passed with options falling back to localhost

[shobhitsharma]

• Operating System: macOS Mojave
• Node Version: 10.15.1
• NPM Version: 6.x
• webpack Version: 4.x
• webpack-dev-server Version: 3.2.0

• This is a bug
• This is a modification request

...
devServer: {
   host: 'custom.local.host' // Gets disregarded
}

[alexander-akait]

@shobhitsharma Please describe you issue more verbosely, what do you mean Breaks host parameter?

[alexander-akait]

Please create minimum reproducible test repo

[miketownsend]

• Operating System: macOS Mojave

• Node Version: 10.15.1

• NPM Version: 6.x

• webpack Version: 4.x

• webpack-dev-server Version: 3.2.0

• This is a bug

• This is a modification request

I am seeing the same issue, and have a project serving html with a local ssl certificate on:
https://app.domain.com:3000

The webpack assets are served on:
https://app.domain.com:8080

Using:

{
  devServer: {
    hot: true,
    inline: true,
    disableHostCheck: true,
    host: '0.0.0.0',
    headers: {
      'Access-Control-Allow-Origin': 'https://app.domain.com:3000'
    },
    https: {
      key: fs.readFileSync(path.join(__dirname, '../localssl/server.key')),
      cert: fs.readFileSync(path.join(__dirname, '../localssl/server.crt'))
    }
  }
}

Chrome now rejects assets from webpack due to ssl certificate host check.

[shobhitsharma]

@evilebottnawi This resolves the issue for me #1686. If you guys have better ideas up there, feel free to commit and let me know.

[phil-lgr]

v3.2.0 broke my --https setup with --host I get the autogenerated certificate instead of the one I pass in parameters

[phil-lgr]

I don't understand the changes here: 0b89fd9#diff-15fb51940da53816af13330d8ce69b4e cc @evilebottnawi

@shobhitsharma It's sad that such a change was merged and released! Hopefully your revert can be merged quickly!

[phil-lgr]

Repro: https://github.com/phil-lgr/repro-https-issue

This in on Windows 10, Node LTS

node -v
v10.14.0

with "webpack-dev-server": "3.1.14":

it actually read the correct key

[phil-lgr]

Looks like v3.2.0 just ignores --cert --key and the other --https args? let me know if you have any questions

[alexander-akait]

@phil-lgr please don't post issue in difference issue, create new issue instead

[shobhitsharma]

@evilebottnawi Please write better testing in future to prevent issues like this.

[alexander-akait]

@shobhitsharma it is open source and i am maintaining many projects and sometimes doesn't have enough time on all test cases, you can help us just send a PR with more tests