Chore/better plugin naming #891
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing {configFile:configFile} to the env.run(generator) as second
argument in packages/utils/modify-config.ts and using this property in generator class to get the
configPath in generator class constructor in remove-generator.ts
added semicolon in line 35
removed the blank line and added space in env.run method 's second argument.
removed the if-statement and added space
Changed the init-generator code to fix the entry point issue when the entry point was answered
…ethsaha/webpack-cli into bugfix/init-entry-point-fix
Changed the init-generator code to fix the entry point issue when the entry point was answered
…ethsaha/webpack-cli into bugfix/init-entry-point-fix
…b.com/anikethsaha/webpack-cli into bugfix/configPath-in-remove-generator
Changed the naming of the webpack plugin for the config file to a better and standard form of naming.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
refactoring
Did you add tests for your changes?
NA
If relevant, did you update the documentation?
NA
Summary
Changed the naming of the current naming of the webpack plugin in the
add-generatorto a better and standard way of naming. The earlier one was creating error name when passed something likeextract-text-webpack-plugin, it would give the plugin in config file like thisplugins: new Extract() - textPlugin,With this refractor
It will output the config file plugin with this
plugins: new ExtractTextWebpackPlugin(),Does this PR introduce a breaking change?
No
Other information
NA