fix(migrate): move options to use #308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sendilkumarn
force-pushed
the
migrate-options
branch
from
c241aea to
5002366
Compare
sendilkumarn
force-pushed
the
migrate-options
branch
from
5002366 to
467b9ad
Compare
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
evenstensberg
approved these changes
Mar 4, 2018
Member
evenstensberg
left a comment
evenstensberg
left a comment
There was a problem hiding this comment.
Lgtm here, @fokusferit @ematipico PTAL
ematipico
suggested changes
Mar 6, 2018
lib/migrate/loaders/loaders.js
Outdated
|
|
||
| const fitOptionsToUse = p => { | ||
| let options; | ||
| p.value.properties.map(prop => { |
Contributor
There was a problem hiding this comment.
.map returns a new array. If you don't assign it, it's better to use .forEach.
lib/migrate/loaders/loaders.js
Outdated
| prop => prop.key.name !== "options" | ||
| ); | ||
|
|
||
| p.value.properties.map(prop => { |
Contributor
There was a problem hiding this comment.
Also here: .forEach is more appropriate
|
@sendilkumarn Thanks for your update. I labeled the Pull Request so reviewers will review it again. @ematipico Please review the new changes. |
ematipico
approved these changes
Mar 7, 2018
This was referenced Mar 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
NA
Summary
Fixes #159
Does this PR introduce a breaking change?
Other information