V2 docs/remove commit validator #222
Conversation
evenstensberg
left a comment
evenstensberg
left a comment
There was a problem hiding this comment.
Nice! Thanks! Yeah, if you could add npm run prepare / yarn prepare to the docs, that would be great!
.gitignore
Outdated
| @@ -1,4 +1,5 @@ | |||
| # External dependencies | |||
| .idea # webstorm/intelliJ ide's etc | |||
There was a problem hiding this comment.
Replace the external dep with ide folders
There was a problem hiding this comment.
sure, sorted 👍
|
|
| * Install the commit validator: `npm run install-commit-validator` | ||
|
|
||
| ### Setup with npm | ||
| * Install the dependencies: `npm install` |
There was a problem hiding this comment.
add npm prepare after the install statement, same for yarn
There was a problem hiding this comment.
ah - seems like prepare is a lifecycle hook for both yarn and npm I wasn't aware of. which means it is auto-run after install.
yarnpkg/yarn#3004
https://iamakulov.com/notes/npm-4-prepublish/
There was a problem hiding this comment.
gotcha! I tend to do it after installing based on habit 😆
evenstensberg
left a comment
evenstensberg
left a comment
There was a problem hiding this comment.
LGTM 
thanks @peter-mouland! Do you want any other issues to work with?
|
@ev1stensberg feel free to let me know anything else that would help you out. I'll see what I can do that doesn't clash with whatever you're already working on. |
3 participants
What kind of change does this PR introduce?
Update Documentation for v2
Did you add tests for your changes?
n/a
If relevant, did you update the documentation?
yes
Summary
Removed any mention of
commit-validatoras it is no longer relevant.I did see a task
prepareis this aprepublishtask? or should the docs now mention this?Does this PR introduce a breaking change?
n/a
Other information