feature(defaults): remove entry and output.path validation #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azz
reviewed
Dec 16, 2017
package.json
Outdated
| "optionalDependencies": { | ||
| "schema-utils": "^0.4.2", | ||
| "webpack": "^4.0.0-alpha.0", | ||
| "webpack": "^4.0.0-alpha.1" |
evenstensberg
approved these changes
Dec 16, 2017
Member
evenstensberg
left a comment
evenstensberg
left a comment
There was a problem hiding this comment.
LGTM 
, thanks! FWIW, if webpack can't find the entry or src code, the validationschema is gonna throw, at least from testing this in the v2 branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature
Did you add tests for your changes?
N/A(?)
If relevant, did you update the documentation?
Does it need to be documented? (We can discuss).
Summary
This PR is a dependent PR for webpack/webpack#6140. The aforementioned PR removes validation tests in favor of sensible defaults.
Turns out removing them exposes outdated entry and output.path validations that lived in the cli at one time. This PR removes those validations.
Does this PR introduce a breaking change?
Other information
Also bumping optional dependency version for webpack to alpha.1