Skip to content

Fix migrate command #1495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Apr 27, 2020
Merged

Fix migrate command #1495

merged 15 commits into from
Apr 27, 2020

Conversation

@knagaitsev
Copy link
Contributor

@knagaitsev knagaitsev commented Apr 23, 2020

What kind of change does this PR introduce?

fix/tests

Did you add tests for your changes?

Yes (still need to add tests for runPrettier)

I'm not exactly sure how the migrate command is supposed to work. Could someone give an example of a webpack config that it should make modifications to?

If relevant, did you update the documentation?

No

Summary

@jamesgeorge007 Sorry for taking over, just couldn't debug runPromptWithAnswers without using your changes. It seems that execa does not like an empty input string option.

  • Fixes runPromptWithAnswers
  • Fixes migrate
  • Fixes issues with runPrettier

Does this PR introduce a breaking change?

Slightly with how runPrettier works

Other information

@knagaitsev knagaitsev requested a review from a team as a code owner April 23, 2020 22:21
@anshumanv
Copy link
Member

anshumanv commented Apr 24, 2020

@Loonride one test unusually still fails, doesn't show any log, can you debug?

@jamesgeorge007
Copy link
Member

jamesgeorge007 commented Apr 24, 2020

I'm not exactly sure how the migrate command is supposed to work. Could someone give an example of a webpack config that it should make modifications to?

You can find everything related to migrate command here

jamesgeorge007
jamesgeorge007 reviewed Apr 24, 2020
View reviewed changes
@knagaitsev
Copy link
Contributor Author

knagaitsev commented Apr 24, 2020

It seems sending a SIGKILL to the process at the end of runPromptWithAnswers made it more stable 🤷‍♀️

@alexander-akait alexander-akait mentioned this pull request Apr 25, 2020
Closed
alexander-akait
alexander-akait previously approved these changes Apr 25, 2020
View reviewed changes
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @webpack/cli-team please review

anshumanv
anshumanv previously approved these changes Apr 25, 2020
View reviewed changes
jamesgeorge007
jamesgeorge007 previously approved these changes Apr 25, 2020
View reviewed changes
@alexander-akait
Copy link
Member

alexander-akait commented Apr 25, 2020

hm, ci is not stable in some cases, it is strange

@knagaitsev
Copy link
Contributor Author

knagaitsev commented Apr 25, 2020

hm, ci is not stable in some cases, it is strange

whats confusing is it always either seems like a large group of them fail, or none of them fail 🤔

@rishabh3112
Copy link
Member

rishabh3112 commented Apr 25, 2020 •
edited
Loading

whats confusing is it always either seems like a large group of them fail, or none of them fail 🤔

Others are cancelled when one of them fails. the macOS Node v13 container is the failing one in every PR:(

@knagaitsev
Copy link
Contributor Author

knagaitsev commented Apr 25, 2020

Others are cancelled when one of them fails. the macOS Node v13 container is the failing one everywhere :(

Oh that makes more sense thanks

@alexander-akait
Copy link
Member

alexander-akait commented Apr 25, 2020

I think we have racing

@webpack-bot
Copy link

webpack-bot commented Apr 25, 2020

@rishabh3112 Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@jamesgeorge007 Please review the new changes.

@knagaitsev
Copy link
Contributor Author

knagaitsev commented Apr 25, 2020

Let me try a few things with how runPromptWithAnswers works.

@knagaitsev
Copy link
Contributor Author

knagaitsev commented Apr 25, 2020 •
edited
Loading

@evilebottnawi 4 test runs good in a row, I think stabilization worked!

What I did was forced runPromptWithAnswers to wait for new stdout before writing the next answer to stdin

@alexander-akait
Copy link
Member

alexander-akait commented Apr 27, 2020

Good job!

@alexander-akait alexander-akait merged commit 7ebcbb8 into webpack:next Apr 27, 2020
This was referenced Apr 27, 2020
Closed
Closed
@jamesgeorge007 jamesgeorge007 linked an issue Apr 27, 2020 that may be closed by this pull request
Migrate functionality doesn't work as expected #1422
Closed
@enterstudio enterstudio mentioned this pull request Jun 20, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes

@anshumanv anshumanv anshumanv approved these changes

@jamesgeorge007 jamesgeorge007 jamesgeorge007 left review comments

Assignees

No one assigned

Labels

PR: reviewed-approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Migrate functionality doesn't work as expected

6 participants

@knagaitsev @anshumanv @jamesgeorge007 @alexander-akait @rishabh3112 @webpack-bot