Skip to content

Conversation

@anshumanv
Copy link
Member

What kind of change does this PR introduce?
updates deps accross all packages.

Did you add tests for your changes?
Yes

If relevant, did you update the documentation?
Not needed

Summary

  • Updated all packages
  • We will enable dependabot after this

Does this PR introduce a breaking change?
Shouldn't ideally

Other information
NA

@anshumanv anshumanv requested a review from a team as a code owner March 17, 2020 13:49
ryanclark
ryanclark previously approved these changes Mar 17, 2020
@alexander-akait
Copy link
Member

Something broken, need investigate and fix it

@anshumanv
Copy link
Member Author

Will take a look. 👍

@anshumanv
Copy link
Member Author

Test is passing locally but not here 😕

If anyone has any ideas about this, please suggest.

@alexander-akait
Copy link
Member

Problem with import * as path from 'path';, just rewrite that line

@anshumanv
Copy link
Member Author

Problem with import * as path from 'path';, just rewrite that line

Problem seems to be something else, looking
image

@anshumanv
Copy link
Member Author

nyc upgrade was the issue, breaking change, reverted it. 👍

Will enable dependabot after this goes in.

@webpack-bot
Copy link

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@alexander-akait
Copy link
Member

@anshumanv please fix conflicts

@alexander-akait
Copy link
Member

Let's merge it and continue development

@alexander-akait alexander-akait merged commit e4e1bb9 into webpack:next Mar 24, 2020
@alexander-akait
Copy link
Member

I think we should check each package for unnecessary dependencies and remove them, it's a simple task

@anshumanv
Copy link
Member Author

I think we should check each package for unnecessary dependencies and remove them, it's a simple task

On it. 👍

@anshumanv anshumanv deleted the deps branch March 24, 2020 12:49
@anshumanv
Copy link
Member Author

Also, enabling dependabot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants