Serve command not passing webpack `devServer` config to webpack-dev-server

[lukereative]

Describe the bug

Serve command not passing webpack devServer config to webpack-dev-server

webpack.dev.js

  devServer: {
    https: isUsingHTTPS && secureLocalDomain,
    host: "myreactapp.test",
    hot: true,
    port: 8080,
    publicPath: "/myreactapp",
    quiet: true,
    proxy: {
      '**': {
        target: localURL,
        secure: false,
        headers: {
          'X-Dev-Server-Proxy': localURL
        }
      }
    }
  }

command used

webpack serve --config webpack.dev.js

What is the current behavior?

The webpack server runs but doesn't pick up all the options from the devServer config. You can see this by webpack output being undefined in the CLI output, but also the proxy was also not working.

ℹ ｢wds｣: Project is running at http://myreactapp.test:8080/
ℹ ｢wds｣: webpack output is served from undefined
ℹ ｢wds｣: Content not from webpack is served from /path/to/my/reactapp

To Reproduce

Relevant entries from package.json

"@webpack-cli/serve": "^1.0.1-alpha.5",
"webpack": "^5.0.0-beta.13",
"webpack-cli": "^4.0.0-beta.8",

Steps to reproduce the behavior:

1. Define a devServer config in your webpack config file
2. Run webpack serve --config webpack.dev.js

Expected behavior

Previously the dev server would pick up devServer config object from your webpack config file

Additional context

If I change line 28 from startDevServer.ts it works as expected but obviously this ignores the cli overrides.

- const server = new Server(compiler, options);
+ const server = new Server(compiler, devServerOptions);

CLI output

ℹ ｢wds｣: Project is running at http://myreactapp.test:8080/
ℹ ｢wds｣: webpack output is served from /eccreactapp/dist
ℹ ｢wds｣: Content not from webpack is served from /path/to/my/reactapp

[anshumanv]

Taking a look, thanks for the report!

[anshumanv]

Found the issue, will fix in a bit. 👍

[anshumanv]

Issue - devServer config was never passed fully to the server.

[anshumanv]

@evilebottnawi even after passing clientLogLevel: "none" or silent in server config, I'm still seeing logs, this should not be the case right?

 ✘  ~/Code/tests  webpack-cli serve --config webpack.config.js
{ liveReload: true,
  serveIndex: true,
  inline: true,
  clientLogLevel: 'silent',
  host: 'localhost',
  port: 1234,
  publicPath: '/',
  hot: true,
  proxy:
   { '**': { target: 'test', secure: false, headers: [Object] } } }
ℹ ｢wds｣: Project is running at http://localhost:1234/
ℹ ｢wds｣: webpack output is served from /
ℹ ｢wds｣: Content not from webpack is served from /Code/tests
⚠ ｢wdm｣: Hash: d28daed123b499d6b1b7
Version: webpack 4.42.1
Time: 350ms
Built at: 04/16/2020 9:51:46 AM
  Asset     Size  Chunks             Chunk Names
main.js  155 KiB       0  [emitted]  main
Entrypoint main = main.js
 [1] ../GitHub/webpack-cli/node_modules/webpack/hot/log.js 1.34 KiB {0} [built]
 [4] ../GitHub/webpack-cli/node_modules/webpack-dev-server/client/utils/log.js 964 bytes {0} [built]
 [5] ../GitHub/webpack-cli/node_modules/webpack/hot/emitter.js 75 bytes {0} [built]
 [6] multi ../GitHub/webpack-cli/node_modules/webpack-dev-server/client?http://localhost:1234 ../GitHub/webpack-cli/node_modules/webpack/hot/dev-server.js ./index.js 52 bytes {0} [built]
 [7] ../GitHub/webpack-cli/node_modules/webpack-dev-server/client?http://localhost:1234 4.29 KiB {0} [built]
 [8] ../GitHub/webpack-cli/node_modules/webpack-dev-server/node_modules/strip-ansi/index.js 161 bytes {0} [built]
[10] ../GitHub/webpack-cli/node_modules/webpack-dev-server/client/socket.js 1.53 KiB {0} [built]
[13] ../GitHub/webpack-cli/node_modules/webpack-dev-server/client/overlay.js 3.51 KiB {0} [built]
[19] ../GitHub/webpack-cli/node_modules/webpack-dev-server/client/utils/sendMessage.js 402 bytes {0} [built]
[20] ../GitHub/webpack-cli/node_modules/webpack-dev-server/client/utils/reloadApp.js 1.59 KiB {0} [built]
[22] ../GitHub/webpack-cli/node_modules/webpack-dev-server/client/utils/createSocketUrl.js 2.91 KiB {0} [built]
[31] ../GitHub/webpack-cli/node_modules/webpack/hot sync nonrecursive ^\.\/log$ 170 bytes {0} [built]
[32] ../GitHub/webpack-cli/node_modules/webpack/hot/dev-server.js 1.59 KiB {0} [built]
[33] ../GitHub/webpack-cli/node_modules/webpack/hot/log-apply-result.js 1.27 KiB {0} [built]
[34] ./index.js 19 bytes {0} [built]
    + 20 hidden modules

WARNING in configuration
The 'mode' option has not been set, webpack will fallback to 'production' for this value. Set 'mode' option to 'development' or 'production' to enable defaults for each environment.
You can also set it to 'none' to disable any default behavior. Learn more: https://webpack.js.org/configuration/mode/
ℹ ｢wdm｣: Compiled with warnings.

Dev server version: webpack-dev-server@3.10.3

[alexander-akait]

@anshumanv yep, because it is logs from server, not from client

[anshumanv]

@anshumanv yep, because it is logs from server, not from client

Yes, But it should pass the devServer object from the config right to DevServer right?

[alexander-akait]

@anshumanv we should get devServer config, override specified CLI flags and send it to dev server

[anshumanv]

@evilebottnawi yep, fix is here - #1470

[lukereative]

Fix is now here #1649

[gabriel-peracio]

This is a pretty major blocker for my workflow, hope this gets solved soon!

[ylemkimon]

#1649 is now merged. I can confirm the issue is fixed with webpack-cli#next and webpack-dev-server#v4.

[Johannestegner]

Will this be released in a new alpha/beta release soon? Would be wonderful to have it working :)