-
-
Notifications
You must be signed in to change notification settings - Fork 645
Description
Is your feature request related to a problem? Please describe.
In the next branch, we're replacing old test in favor for new ones. We can still use logic from the old test suite, but we need to write new assertions. Those include:
- create
- migrate
- loader
- plugin
- info
- negated flags
- entry
- dotfolder lookup
- output
- watch
- merge
- global
- sourcemap
- help
- json
- dev
- prod
- version
- config
Describe the solution you'd like
As listed in the previous section, these are the arguments we need to test. In addition, we need a replacement for the mode property, by reading the node env instead or by letting users pass the environment as a param to the webpack config, maybe both. I prefer that we read the node environment, because this means that we'll opt out of having to support a flag for setting mode, rather users can use the environment to set webpack mode.
Furthermore, we need to in specific, test the way we combine the cli arguments with a config specified, in such fashion that we know that we're not creating any bugs.
I'd prefer that CLI arguments outrule configuration, but I'm open for discussion on that part.
Describe alternatives you've considered
N/A
Additional context
Please comment in this issue for questions instead of reaching out to my personal accounts. This way it's public and everyone can chime in on what's happening.