Skip to content

Conversation

@snitin315
Copy link
Member

@snitin315 snitin315 commented May 25, 2021

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Update deps

Breaking Changes

NO

Additional Info

No

@codecov
Copy link

codecov bot commented May 25, 2021

Codecov Report

Merging #128 (077f87b) into master (cc29077) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #128   +/-   ##
=======================================
  Coverage   97.57%   97.57%           
=======================================
  Files           6        6           
  Lines         700      700           
  Branches      299      299           
=======================================
  Hits          683      683           
  Misses         15       15           
  Partials        2        2           
Impacted Files Coverage Δ
src/ValidationError.js 96.69% <100.00%> (ø)
src/util/hints.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc29077...077f87b. Read the comment docs.

export type ValidationErrorConfiguration =
import('./validate').ValidationErrorConfiguration;
export type PostFormatter = import('./validate').PostFormatter;
export type SchemaUtilErrorObject = import('./validate').SchemaUtilErrorObject;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you test it manually? Don't want to break types, sometimes ts have small problems

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good,
In ./validate -

export type Schema =
| (import('json-schema').JSONSchema4 & Extend)
| (import('json-schema').JSONSchema6 & Extend)
| (import('json-schema').JSONSchema7 & Extend);

export type ValidationErrorConfiguration = {
name?: string | undefined;
baseDataPath?: string | undefined;
postFormatter?: PostFormatter | undefined;
};

export type PostFormatter = (
formattedError: string,
error: SchemaUtilErrorObject
) => string;

export type SchemaUtilErrorObject = Ajv.ErrorObject & {
children?: Ajv.ErrorObject[] | undefined;
};

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, thanks!

@alexander-akait alexander-akait merged commit ae3b128 into webpack:master May 25, 2021
@snitin315 snitin315 deleted the deps-update branch May 25, 2021 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants