-
-
Notifications
You must be signed in to change notification settings - Fork 39
chore: update dev-deps #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #128 +/- ##
=======================================
Coverage 97.57% 97.57%
=======================================
Files 6 6
Lines 700 700
Branches 299 299
=======================================
Hits 683 683
Misses 15 15
Partials 2 2
Continue to review full report at Codecov.
|
| export type ValidationErrorConfiguration = | ||
| import('./validate').ValidationErrorConfiguration; | ||
| export type PostFormatter = import('./validate').PostFormatter; | ||
| export type SchemaUtilErrorObject = import('./validate').SchemaUtilErrorObject; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you test it manually? Don't want to break types, sometimes ts have small problems
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good,
In ./validate -
schema-utils/declarations/validate.d.ts
Lines 11 to 14 in cc29077
| export type Schema = | |
| | (import('json-schema').JSONSchema4 & Extend) | |
| | (import('json-schema').JSONSchema6 & Extend) | |
| | (import('json-schema').JSONSchema7 & Extend); |
schema-utils/declarations/validate.d.ts
Lines 22 to 26 in cc29077
| export type ValidationErrorConfiguration = { | |
| name?: string | undefined; | |
| baseDataPath?: string | undefined; | |
| postFormatter?: PostFormatter | undefined; | |
| }; |
schema-utils/declarations/validate.d.ts
Lines 18 to 21 in cc29077
| export type PostFormatter = ( | |
| formattedError: string, | |
| error: SchemaUtilErrorObject | |
| ) => string; |
schema-utils/declarations/validate.d.ts
Lines 15 to 17 in cc29077
| export type SchemaUtilErrorObject = Ajv.ErrorObject & { | |
| children?: Ajv.ErrorObject[] | undefined; | |
| }; |
alexander-akait
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, thanks!
This PR contains a:
Motivation / Use-Case
Update deps
Breaking Changes
NO
Additional Info
No