Skip to content
This repository was archived by the owner on Oct 7, 2025. It is now read-only.

Conversation

@DanielRuf
Copy link
Contributor

@DanielRuf DanielRuf commented May 10, 2018

This adds the Node.js 10 image to the default configurations.
Reference: webpack/mini-css-extract-plugin#136 (comment)

Copy link
Contributor

@shellscape shellscape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node9 needs to be removed from the config along with these changes.

also, @d3viant0ne does the webpackcontrib/circleci-node10:latest image actually exist yet?

@alexander-akait
Copy link
Member

@shellscape
Copy link
Contributor

@DanielRuf
Copy link
Contributor Author

nice, but looks like there's a name mismatch

In which way? Do we need the JDK 9?

@DanielRuf
Copy link
Contributor Author

@shellscape
Copy link
Contributor

@DanielRuf ok, alex just pointed me to the wrong image. you'll still need to remove the node 9 sections from the config though.

@DanielRuf
Copy link
Contributor Author

@DanielRuf ok, alex just pointed me to the wrong image. you'll still need to remove the node 9 sections from the config though.

Done.

@shellscape shellscape merged commit cc5052e into webpack-contrib:master May 11, 2018
@DanielRuf DanielRuf deleted the chore/add-nodejs-10-image branch May 11, 2018 19:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants